Skip to content

gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc - #136740

Merged
freakboy3742 merged 3 commits into
python:mainfrom
hoodmane:emscripten-set-umask-zero
Jul 17, 2025
Merged

gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc#136740
freakboy3742 merged 3 commits into
python:mainfrom
hoodmane:emscripten-set-umask-zero

Conversation

@hoodmane

@hoodmanehoodmane commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

This fixes test_apropos_empty_doc. Much thanks to @freakboy3742 for the investigation.

We think this will fix `test_apropos_empty_doc`.
@hoodmane

Copy link
Copy Markdown
ContributorAuthor

!buildbot emscripten

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 595781e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane

hoodmane commented Jul 17, 2025

Copy link
Copy Markdown
ContributorAuthor

So the test passes with a umask of 077 on native Python but fails with a umask of 077 in Emscripten Python. I will try to understand why.

@hoodmane

Copy link
Copy Markdown
ContributorAuthor

!buildbot emscripten

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 643e889 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@freakboy3742freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jul 17, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) July 17, 2025 15:12
@hoodmanehoodmane changed the title gh-127146: Emscripten: Set umask to zero in python.shgh-127146: Emscripten: Set umask to zero in test_apropos_empty_docJul 17, 2025
@freakboy3742
freakboy3742 merged commit 22af5d3 into python:mainJul 17, 2025
78 of 80 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2025
…-136740)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-136745 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 17, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 17, 2025
…) (#136745)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…36740)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…36740)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…ythonGH-136740) (python#136745)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hoodmane@bedevere-bot@freakboy3742