Skip to content

gh-136438: Make sure test_remote_pdb pass with all optimization levels - #136788

Merged
encukou merged 3 commits into
python:mainfrom
olp-cs:gh-136438-fix-OO
Jul 20, 2025
Merged

gh-136438: Make sure test_remote_pdb pass with all optimization levels#136788
encukou merged 3 commits into
python:mainfrom
olp-cs:gh-136438-fix-OO

Conversation

@olp-cs

@olp-csolp-cs commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #136438

  • New test cases for the scenario when no help is available.
  • Skip test cases not relevant for the current optimization level.

Details

Help is not available for the optimization level -OO.

please do not run Python with -OO if you need command help

(pdb.py, lines 2439-2440)

Testing

With -OO

./python -OO -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available) ... skipped 'Help not available for -OO'
test_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available) ... ok

Without -OO

./python -m test test_remote_pdb -v

test_handling_help_when_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_available)
Test handling help requests when help is available. ... ok
test_handling_help_when_not_available (test.test_remote_pdb.PdbClientTestCase.test_handling_help_when_not_available)
Test handling help requests when help is not available. ... skipped 'Needs -OO'

At EuroPython Sprints with @encukou

@python-cla-bot

python-cla-botBot commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appBot added awaiting review tests Tests in the Lib/test dir labels Jul 19, 2025
@bedevere-app

bedevere-appBot commented Jul 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-appbedevere-appBot mentioned this pull request Jul 19, 2025
Closed
8 tasks
encukou
encukou approved these changes Jul 19, 2025
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's merge this :)

Please don't update the branch; GitHub has a prominent button fo that but all it does here is restart the test run.

ZeroIntensity
ZeroIntensity approved these changes Jul 19, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity

ZeroIntensity commented Jul 19, 2025

Copy link
Copy Markdown
Member

Oh, oops, you beat me to it.

@encukou
encukou merged commit 588d9fb into python:mainJul 20, 2025
46 checks passed
@encukouencukou added the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
@miss-islington-app

miss-islington-appBot commented Jul 20, 2025

Copy link
Copy Markdown

Thanks @olp-cs for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Jul 20, 2025

Copy link
Copy Markdown

Sorry, @olp-cs and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 588d9fb84ae014502811ec8580411ea0df7200fe 3.14

@encukou

encukou commented Jul 20, 2025

Copy link
Copy Markdown
Member

Thank you, @olp-cs?
Would you be interested in backporting this into the 3.14 branch?

@olp-cs

olp-cs commented Jul 20, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@encukou Thank you, I'll look into this!

Update: backport to 3.14 #136855

olp-cs added a commit to olp-cs/cpython that referenced this pull request Jul 20, 2025
@olp-cs
pythongh-136438: Make suretest_remote_pdbpass with all optimizati…
8d07aa9
…on levels (pythonGH-136788)
(cherry picked from commit 588d9fb)
@olp-csolp-cs mentioned this pull request Jul 20, 2025
Merged
@bedevere-app

bedevere-appBot commented Jul 20, 2025

Copy link
Copy Markdown

GH-136855 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
encukou pushed a commit that referenced this pull request Jul 20, 2025
@olp-cs
[3.14]gh-136438: Make suretest_remote_pdbpass with all optimizat…
0e90926
…ion levels (GH-136788) (GH-136855)
(cherry picked from commit 588d9fb)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@olp-cs@taegyunkim
pythongh-136438: Make suretest_remote_pdbpass with all optimizati…
4536a4a
…on levels (pythonGH-136788)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@olp-cs@Agent-Hellboy
pythongh-136438: Make suretest_remote_pdbpass with all optimizati…
7a7c02b
…on levels (pythonGH-136788)
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@olp-cs@kumaraditya303
[3.14]pythongh-136438: Make suretest_remote_pdbpass with all opt…
a5658ab
…imization levels (pythonGH-136788) (pythonGH-136855)
(cherry picked from commit 588d9fb)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes
@ZeroIntensityZeroIntensityZeroIntensity approved these changes
@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian is a code owner

Assignees

@encukouencukou

Labels

skip newssprinttestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@olp-cs@ZeroIntensity@encukou@AA-Turner@StanFromIreland