Skip to content

gh-54732: Make argparse error caused by empty rows in option files explicit - #136795

Merged
AA-Turner merged 6 commits into
python:mainfrom
jdunter:doc_argparse_empty_rows
Jul 19, 2025
Merged

gh-54732: Make argparse error caused by empty rows in option files explicit#136795
AA-Turner merged 6 commits into
python:mainfrom
jdunter:doc_argparse_empty_rows

Conversation

@jdunter

@jdunterjdunter commented Jul 19, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adds a Note to the documentation, that addresses the error caused by an empty row in an argparse option file.

📚 Documentation preview 📚: https://cpython-previews--136795.org.readthedocs.build/

@python-cla-bot

python-cla-botBot commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Jul 19, 2025
@StanFromIrelandStanFromIreland changed the title Addresses #54732: Make argparse error caused by empty rows in option files explicit.gh-54732: Make argparse error caused by empty rows in option files explicit.Jul 19, 2025
@bedevere-appbedevere-appBot mentioned this pull request Jul 19, 2025
Closed
@StanFromIreland

StanFromIreland commented Jul 19, 2025

Copy link
Copy Markdown
Member

Please use the format you have in the issue description for the title, it allows our automation to link it. You also need to sign the CLA.

@jdunter
jdunterforce-pushed the doc_argparse_empty_rows branch from d2dd1e9 to 1cfa51bCompareJuly 19, 2025 11:53
StanFromIreland
StanFromIreland reviewed Jul 19, 2025
View reviewed changes
Comment threadDoc/library/argparse.rst Outdated
Comment threadDoc/library/argparse.rst Outdated
StanFromIreland
StanFromIreland reviewed Jul 19, 2025
View reviewed changes
Comment threadDoc/library/argparse.rst Outdated
@StanFromIreland

StanFromIreland commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.

@jdunter
pythongh-54732: Address suggestions from PR Discussion.
d2f76e4
Namely the use of code markup.
Also I fixed a trailing whitespace.
@AA-TurnerAA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 19, 2025
@AA-TurnerAA-Turner changed the title gh-54732: Make argparse error caused by empty rows in option files explicit.gh-54732: Make argparse error caused by empty rows in option files explicitJul 19, 2025
@jdunter
pythongh-54732: Address suggestions from real life PR Discussion.
ea51887
Change two of the phrasings to make it more clear.
Use straight quotes.
AA-Turner
AA-Turner reviewed Jul 19, 2025
View reviewed changes
Comment threadDoc/library/argparse.rst Outdated
@AA-Turner
AA-Turner enabled auto-merge (squash) July 19, 2025 14:03
@AA-Turner
AA-Turner merged commit 8ffc3ef into python:mainJul 19, 2025
31 of 32 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsJul 19, 2025
@miss-islington-app

miss-islington-appBot commented Jul 19, 2025

Copy link
Copy Markdown

Thanks @jdunter for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@jdunter@AA-Turner@miss-islington
pythongh-54732: Make argparse error caused by empty rows in option fi…
e5cb5db
…les explicit (pythonGH-136795)
(cherry picked from commit 8ffc3ef)
Co-authored-by: jdunter <2ve@mailbox.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
@jdunter@AA-Turner@miss-islington
pythongh-54732: Make argparse error caused by empty rows in option fi…
0b864bf
…les explicit (pythonGH-136795)
(cherry picked from commit 8ffc3ef)
Co-authored-by: jdunter <2ve@mailbox.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jul 19, 2025

Copy link
Copy Markdown

GH-136818 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
@bedevere-app

bedevere-appBot commented Jul 19, 2025

Copy link
Copy Markdown

GH-136819 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2025
AA-Turner added a commit that referenced this pull request Jul 19, 2025
@miss-islington@jdunter@AA-Turner
[3.14]gh-54732: Make argparse error caused by empty rows in option f…
8d063f3
…iles explicit (GH-136795) (#136818)
gh-54732: Make argparse error caused by empty rows in option files explicit (GH-136795)
(cherry picked from commit 8ffc3ef)
Co-authored-by: jdunter <2ve@mailbox.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Jul 19, 2025
@miss-islington@jdunter@AA-Turner
[3.13]gh-54732: Make argparse error caused by empty rows in option f…
2d0f169
…iles explicit (GH-136795) (#136819)
gh-54732: Make argparse error caused by empty rows in option files explicit (GH-136795)
(cherry picked from commit 8ffc3ef)
Co-authored-by: jdunter <2ve@mailbox.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@jdunter@AA-Turner@taegyunkim
pythongh-54732: Make argparse error caused by empty rows in option fi…
6b01dd5
…les explicit (python#136795)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@jdunter@AA-Turner@Agent-Hellboy
pythongh-54732: Make argparse error caused by empty rows in option fi…
78c1d70
…les explicit (python#136795)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington@jdunter
@AA-Turner@kumaraditya303
[3.14]pythongh-54732: Make argparse error caused by empty rows in op…
d695c73
…tion files explicit (pythonGH-136795) (python#136818)
pythongh-54732: Make argparse error caused by empty rows in option files explicit (pythonGH-136795)
(cherry picked from commit 8ffc3ef)
Co-authored-by: jdunter <2ve@mailbox.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@savannahostrowskisavannahostrowski mentioned this pull request Jun 5, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments
@AA-TurnerAA-TurnerAA-Turner approved these changes
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip newssprint

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdunter@StanFromIreland@AA-Turner