Skip to content

Refactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checks - #136815

Merged
brettcannon merged 7 commits into
python:mainfrom
anistark:is_wasm
Jul 22, 2025
Merged

Refactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checks#136815
brettcannon merged 7 commits into
python:mainfrom
anistark:is_wasm

Conversation

@anistark

@anistarkanistark commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@python-cla-bot

python-cla-botBot commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

This comment was marked as resolved.

Sign in to view
@StanFromIrelandStanFromIreland added skip issue skip news type-refactor Code refactoring (with no changes in behavior) tests Tests in the Lib/test dir labels Jul 19, 2025
@hoodmane

hoodmane commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

Cc @brettcannon . I'm okay with it if he is.

@hoodmane

hoodmane commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

@ambv says it needs to be is_wasm32 to make it more than one character different from is_wasi.

@anistark

anistark commented Jul 19, 2025

Copy link
Copy Markdown
ContributorAuthor

@ambv says it needs to be is_wasm32 to make it more than one character different from is_wasi.

Done.

@brettcannonbrettcannon changed the title Refactor: Use is_wasm flag for is_emscripten or is_wasi for generic checksRefactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checksJul 21, 2025
brettcannon
brettcannon requested changes Jul 21, 2025
View reviewed changes

@brettcannonbrettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I can't edit the PR, so I'm asking for what looks like a redundant comment addition to be removed.

Comment threadLib/test/support/__init__.py Outdated
@bedevere-app

bedevere-appBot commented Jul 21, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

anistarkand others added 2 commits July 22, 2025 02:15
@anistark

anistark commented Jul 21, 2025

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-app

bedevere-appBot commented Jul 21, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app
bedevere-appBot requested a review from brettcannonJuly 21, 2025 20:46
@brettcannon
brettcannon merged commit aafb143 into python:mainJul 22, 2025
40 checks passed
@brettcannon

brettcannon commented Jul 22, 2025

Copy link
Copy Markdown
Member

Thanks, @anistark !

@anistark

anistark commented Jul 22, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks for review 🙌🏼

@anistark
anistark deleted the is_wasm branch July 22, 2025 20:01
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@anistark@brettcannon@taegyunkim
Use test.support.is_wasm32 flag for is_emscripten or is_wasi fo…
6dffc82
…r generic checks (pythonGH-136815)
Co-authored-by: Brett Cannon <brett@python.org>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@anistark@brettcannon@Agent-Hellboy
Use test.support.is_wasm32 flag for is_emscripten or is_wasi fo…
786c542
…r generic checks (pythonGH-136815)
Co-authored-by: Brett Cannon <brett@python.org>
@AA-TurnerAA-Turner added the needs backport to 3.14 bugs and security fixes label Sep 8, 2025
@miss-islington-app

miss-islington-appBot commented Sep 8, 2025

Copy link
Copy Markdown

Thanks @anistark for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
@anistark@brettcannon@miss-islington
Use test.support.is_wasm32 flag for is_emscripten or is_wasi fo…
7bb3583
…r generic checks (pythonGH-136815)
(cherry picked from commit aafb143)
Co-authored-by: Ani <5357586+anistark@users.noreply.github.com>
Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app

bedevere-appBot commented Sep 8, 2025

Copy link
Copy Markdown

GH-138643 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Sep 8, 2025
@AA-TurnerAA-Turner mentioned this pull request Sep 8, 2025
Merged
hugovk pushed a commit that referenced this pull request Sep 8, 2025
@miss-islington@anistark@brettcannon
[3.14] Use test.support.is_wasm32 flag for is_emscripten or `is_w…
5074241
…asi` for generic checks (GH-136815) (#138643)
Co-authored-by: Ani <5357586+anistark@users.noreply.github.com>
Co-authored-by: Brett Cannon <brett@python.org>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington@anistark
@brettcannon@kumaraditya303
[3.14] Use test.support.is_wasm32 flag for is_emscripten or `is_w…
e150291
…asi` for generic checks (pythonGH-136815) (python#138643)
Co-authored-by: Ani <5357586+anistark@users.noreply.github.com>
Co-authored-by: Brett Cannon <brett@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@hoodmanehoodmanehoodmane approved these changes
@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner
@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

No one assigned

Labels

skip issueskip newstestsTests in the Lib/test dirtype-refactorCode refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anistark@hoodmane@brettcannon@AA-Turner@StanFromIreland