Uh oh!
There was an error while loading. Please reload this page.
GH-132732: Use pure op machinery to optimize COMPARE_OP_INT/FLOAT/STR - #137062
Conversation
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Awesome work! This LGTM, just a few nits for the comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tomasr8
left a comment
There was a problem hiding this comment.
LGTM :) just one question: this also adds the _POP_TWO_LOAD_CONST_INLINE_BORROW optimization to other ops like _BINARY_OP_ADD_FLOAT and others. Is it worth to add tests for these ops as well?
Essentially something like test_compare_op_float_pop_two_load_const_inline_borrow but adapted for _BINARY_OP_ADD_FLOAT, etc.. This would mean adding quite a few tests so I'm not sure if it makes sense.
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Let's leave it open for a few more days in case someone else wants to leave any comments, then merge it! |
brandtbucher
left a comment
There was a problem hiding this comment.
This is great! I'd love to see it extended (later) to handle even more cases.
savannahostrowski
commented
Jul 26, 2025
Chatted with Brandt and I think I'm going to land this PR as is. I plan to go back and do a pass to add more optimizations with |
Uh oh!
There was an error while loading. Please reload this page.
…OAT/STR` (python#137062) Co-authored-by: Ken Jin <kenjin4096@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.