Skip to content

[3.14] gh-136759: rename lock.h to pylock.h (GH-137041) - #137072

Closed
miss-islington wants to merge 2 commits into
python:3.14from
miss-islington:backport-ec02db5-3.14
Closed

[3.14] gh-136759: rename lock.h to pylock.h (GH-137041)#137072
miss-islington wants to merge 2 commits into
python:3.14from
miss-islington:backport-ec02db5-3.14

Conversation

@miss-islington

@miss-islingtonmiss-islington commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Rename lock.h to pylock.h to avoid conflicts with headers of other projects.
(cherry picked from commit ec02db5)

Co-authored-by: AN Long aisk@users.noreply.github.com

Rename `lock.h` to `pylock.h` to avoid conflicts with headers of other projects.
(cherry picked from commit ec02db5)
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@aisk

aisk commented Jul 24, 2025

Copy link
Copy Markdown
Member

All PRs on 3.14 branch are failing, so I don't think this is related and we can wait for the fix.

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be all good.

@aisk

aisk commented Aug 12, 2025

Copy link
Copy Markdown
Member

According to #137075, I think we should close this.

@aiskaisk closed this Aug 12, 2025
@miss-islington
miss-islington deleted the backport-ec02db5-3.14 branch January 2, 2026 18:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington@aisk@ZeroIntensity@kumaraditya303@zware