Uh oh!
There was an error while loading. Please reload this page.
gh-131876: extract _hashlib helpers into a separate directory - #137319
gh-131876: extract _hashlib helpers into a separate directory#137319picnixz wants to merge 1 commit into
_hashlib helpers into a separate directory#137319Conversation
259a802 to
ffe7db7Compare…python#136995) The `Modules/hashlib.h` helper file is now removed and split into multiple files: * `Modules/_hashlib/hashlib_buffer.h` -- Utilities for getting a buffer view and handling buffer inputs. * `Modules/_hashlib/hashlib_fetch.h` -- Utilities used when fetching a message digest from a digest-like identifier. Currently, this file only contains common error messages as the fetching API is not yet implemented. * `Modules/_hashlib/hashlib_mutex.h` -- Utilities for managing the lock on cryptographic hash objects.
ffe7db7 to
2fb8a6cCompare
This comment was marked as resolved.
This comment was marked as resolved.
serhiy-storchaka
commented
Aug 3, 2025
What is the point of splitting a header file into three? |
picnixz
commented
Aug 3, 2025
Maintainability for me. This will grow into more code when I plan to move some of the OpenSSL fetch interface from _hashopenssl there as I want to be able to use it in HMAC as well. However I had linker issues :( so for now I wanted to lay out the structure first. What I can do is hold this change and design the fetch API. Then merge both of them at the same time. |
freakboy3742
commented
Aug 6, 2025
!buildbot emscripten |
bedevere-bot
commented
Aug 6, 2025
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 2fb8a6c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137319%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Huh so this also fails for EMscripten (or maybe it was another error). I'll just close this one, we don't really need to split it for now. I don't have time for the follow-up work now. |
So this reverts the revert and fixes the WASM build. The WASI build was not affected but it should have been I think but I can't seem to make it fail (maybe duplicated symbols are allowed?)
_hashliband_hmac#131876