Uh oh!
There was an error while loading. Please reload this page.
GH-137630: Convert _interpqueues to use Argument Clinic - #137685
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
There is a bug in the current code which should be fixed in 3.14 too. The rest LGTM. But I would like to get @ericsnowcurrently's approve.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
commented
Aug 12, 2025
I also add that after removing the return pseudo-annotation, some docstrings look more self-contadicting. It was in the old docstrings, but with |
# Conflicts: # Modules/_interpqueuesmodule.c
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Technically LGTM, but what would @ericsnowcurrently say?
It is sad that this cannot be backported to 3.14, so there will be such large difference between 3.14 and 3.15.
Uh oh!
There was an error while loading. Please reload this page.
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Considering everything stays the same functionally (per all the passing tests), I don't really have any meaningful objections, especially since this is an internal module where I do not expect anyone to ever look at the docstrings. In fact, we could probably change all the docstrings to comments.
FWIW, my review comments are mostly me fussing about argument clinic, which is probably way too late to be relevant. :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
commented
Sep 17, 2025
Thanks both for the reviews! A |
Note, we use a custom converter
qidarg_converterhere. I have changed theqidarg_converter()function to simplify the return -- we only ever useqidarg.id.pydoc diff:
A
_interpretersto Argument Clinic #137630