Skip to content

gh-95534: Convert ZlibDecompressor.__new__ to AC - #137923

Merged
AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:clinic/zlibdecompressor
Aug 19, 2025
Merged

gh-95534: Convert ZlibDecompressor.__new__ to AC#137923
AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:clinic/zlibdecompressor

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Aug 18, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@AA-Turner
AA-Turner requested a review from picnixzAugust 18, 2025 19:33
AA-Turner
AA-Turner commented Aug 18, 2025
View reviewed changes
Comment threadModules/zlibmodule.c
@AA-TurnerAA-Turner changed the title Convert ZlibDecompressor.__new__ to ACgh-95534: Convert ZlibDecompressor.__new__ to ACAug 18, 2025
@bedevere-appbedevere-appBot mentioned this pull request Aug 18, 2025
Closed
picnixz
picnixz reviewed Aug 18, 2025
View reviewed changes
Comment threadModules/zlibmodule.c
Comment threadModules/zlibmodule.c
Comment threadModules/zlibmodule.c
{Py_tp_new, ZlibDecompressor__new__},
{Py_tp_doc, (char *)ZlibDecompressor__new____doc__},
{Py_tp_new, zlib__ZlibDecompressor},
{Py_tp_doc, (char *)zlib__ZlibDecompressor__doc__},

@picnixzpicnixzAug 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something separate, but I think AC should give the possibility to create docstrings for class and module directives as well.

Comment threadModules/zlibmodule.c
@AA-Turner
AA-Turner requested a review from picnixzAugust 18, 2025 20:37
picnixz
picnixz approved these changes Aug 19, 2025
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AA-Turner
AA-Turner merged commit bb75dec into python:mainAug 19, 2025
46 checks passed
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@AA-Turner@Agent-Hellboy
pythongh-95534: ConvertZlibDecompressor.__new__to AC (python#13…
f80e241
…7923)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

skip newstopic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@picnixz