Skip to content

gh-138122: Implement PEP 799 - #138142

Merged
pablogsal merged 10 commits into
python:mainfrom
pablogsal:gh-138122
Aug 27, 2025
Merged

gh-138122: Implement PEP 799#138142
pablogsal merged 10 commits into
python:mainfrom
pablogsal:gh-138122

Conversation

@pablogsal

@pablogsalpablogsal commented Aug 25, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Aug 25, 2025
Open
AA-Turner
AA-Turner reviewed Aug 25, 2025
View reviewed changes
Comment threadLib/profiling/__init__.py Outdated
Comment threadLib/profiling/sampling/__init__.py Outdated
Comment threadLib/profiling/sampling/__init__.py
Comment threadLib/profiling/sampling/__main__.py
Comment threadLib/profiling/tracing/__init__.py Outdated
Comment threadLib/profiling/tracing/__init__.py Outdated
Comment threadLib/profiling/tracing/__init__.py
Comment threadLib/profiling/tracing/__main__.py Outdated
Comment threadLib/profiling/tracing/__init__.py Outdated
pablogsaland others added 3 commits August 26, 2025 15:57
@pablogsal@AA-Turner
Apply suggestions from code review
b2ec363
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@pablogsal
Move stuff to common module
3277076
@pablogsal
Fix lint
716dc9c
@pablogsal

pablogsal commented Aug 26, 2025

Copy link
Copy Markdown
MemberAuthor

@encukou do you happen to know what I am missing for android?

@mhsmith

mhsmith commented Aug 26, 2025

Copy link
Copy Markdown
Member

I think profiling/tracing is missing from the directory list in Makefile.pre.in. Apparently Android is the only platform that runs the tests from a directory generated using make install.

AA-Turner
AA-Turner reviewed Aug 26, 2025
View reviewed changes
Comment threadMakefile.pre.in Outdated
pablogsaland others added 2 commits August 26, 2025 23:14
@pablogsal@AA-Turner
Update Makefile.pre.in
1fa7d39
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@pablogsal
Small fix
228133d
pablogsal
pablogsal commented Aug 27, 2025
View reviewed changes
Comment threadLib/profiling/sampling/__init__.py Outdated
encukou
encukou reviewed Aug 27, 2025
View reviewed changes
Comment threadLib/profiling/sampling/sample.py
@pablogsal
pablogsal merged commit 56eb6b6 into python:mainAug 27, 2025
81 of 83 checks passed
@pablogsal
pablogsal deleted the gh-138122 branch August 27, 2025 16:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments
@AA-TurnerAA-TurnerAA-Turner left review comments
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal@mhsmith@encukou@AA-Turner