gh-73487: Convert _decimal to use Argument Clinic (part 7)

[skirpichev]

• use "defining class" converter, where possible
• convert Context._unsafe* to Argument Clinic

• Issue: decimal: Use Argument Clinic #73487

[AA-Turner]

Looks ok from a desk review, barring Serhiy's comments.

A

[serhiy-storchaka]

Are there any uses of get_module_state_by_def() left?

[skirpichev]

Are there any uses of get_module_state_by_def() left?

Yes, a lot:

$ git grep get_module_state_by_def Modules/_decimal
Modules/_decimal/_decimal.c:get_module_state_by_def(PyTypeObject *tp)
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(v));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(type);
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(type);
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(dec));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(dec));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self)); \
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(dec));
Modules/_decimal/_decimal.c: decimal_state *state = get_module_state_by_def(Py_TYPE(self));

I'll double check, some case could be converted to use "defining class" converter (e.g. _decimal.Decimal.as_tuple), but not all.

Edit: I think nothing left.

[skirpichev]

@serhiy-storchaka, do you think anything left to address issue?

[serhiy-storchaka]

Minor question, and LGTM. 👍

[vstinner]

LGTM

[vstinner]

Merged, thanks.