Uh oh!
There was an error while loading. Please reload this page.
gh-116946: add Py_TPFLAGS_IMMUTABLETYPE to select.[e]poll - #138340
Merged
kumaraditya303 merged 5 commits intoSep 2, 2025
Conversation
picnixz
commented
Sep 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
marked this pull request as draft
September 1, 2025 18:56
select.[e]pollselect.[e]pollpicnixzforce-pushed
the
fix/gc/select-heap-types-116946
branch
from
September 2, 2025 08:32
50a32c4 to
55c88e4Comparepicnixzforce-pushed
the
fix/gc/select-heap-types-116946
branch
from
September 2, 2025 08:33
55c88e4 to
775f809Comparepicnixz
marked this pull request as ready for review
September 2, 2025 08:35
select.[e]pollPy_TPFLAGS_IMMUTABLETYPE to select.[e]pollpicnixz
commented
Sep 2, 2025
Uh oh!
There was an error while loading. Please reload this page.
vstinner
approved these changes
Sep 2, 2025
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
I don't know if "cannot create cycles as it only contains exact ints" comment is correct or not.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
commented
Sep 2, 2025
MemberAuthor
That's why I actually asked. The ints are constructed internally (AFAIU) so I that's why I didn't visit the dictionary. But I can visit it just to be sure. |
kumaraditya303
approved these changes
Sep 2, 2025
…xXNGD.rst Co-authored-by: Victor Stinner <vstinner@python.org>
kumaraditya303
enabled auto-merge (squash)
September 2, 2025 17:28
Uh oh!
There was an error while loading. Please reload this page.
lkollar pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about kqueue as I can't check this myself. However note the following leak on main:
Instead of implementing the full GC protocol, we can make the types immutable.
Rationale for not backporting this: #138341 (comment).