Skip to content

gh-101100: Resolve reference warnings in reference/ - #138418

Merged
AA-Turner merged 5 commits into
python:mainfrom
AA-Turner:docs/refwarn/datamodel
Sep 8, 2025
Merged

gh-101100: Resolve reference warnings in reference/#138418
AA-Turner merged 5 commits into
python:mainfrom
AA-Turner:docs/refwarn/datamodel

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Sep 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@AA-TurnerAA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 3, 2025
@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels Sep 3, 2025
@AA-TurnerAA-Turner mentioned this pull request Sep 3, 2025
Closed
@AA-TurnerAA-Turner changed the title Resolve reference warnings in reference/GH-101100: Resolve reference warnings in reference/Sep 3, 2025
@bedevere-appbedevere-appBot mentioned this pull request Sep 3, 2025
Closed
@AA-Turner
AA-Turner marked this pull request as ready for review September 3, 2025 00:27
@AA-Turner
AA-Turner marked this pull request as draft September 3, 2025 00:27
@AA-Turner
AA-Turner marked this pull request as ready for review September 3, 2025 20:46
@hugovkhugovk changed the title GH-101100: Resolve reference warnings in reference/gh-101100: Resolve reference warnings in reference/Sep 8, 2025
@hugovk

hugovk commented Sep 8, 2025

Copy link
Copy Markdown
Member

@hugovk changed the title
GH-101100: Resolve reference warnings in reference/
gh-101100: Resolve reference warnings in reference/

The convention is gh for issues and GH for PRs :)

Here “gh-12345” is the GitHub issue number, and “GH-NNNN” is the number of the original pull request.

https://devguide.python.org/core-team/committing/#backporting-changes-to-an-older-version

hugovk
hugovk reviewed Sep 8, 2025
View reviewed changes
Comment threadDoc/reference/datamodel.rst Outdated
@AA-Turner@hugovk
Update Doc/reference/datamodel.rst
e5f1a5b
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner
AA-Turner enabled auto-merge (squash) September 8, 2025 19:25
@AA-Turner
AA-Turner merged commit 6831634 into python:mainSep 8, 2025
27 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsSep 8, 2025
@miss-islington-app

miss-islington-appBot commented Sep 8, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
@AA-Turner@miss-islington
pythongh-101100: Resolve reference warnings in reference/ (pythonGH-1…
2d635ec
…38418)
(cherry picked from commit 6831634)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2025
@AA-Turner@miss-islington
pythongh-101100: Resolve reference warnings in reference/ (pythonGH-1…
586b25e
…38418)
(cherry picked from commit 6831634)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Sep 8, 2025

Copy link
Copy Markdown

GH-138680 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Sep 8, 2025
@bedevere-app

bedevere-appBot commented Sep 8, 2025

Copy link
Copy Markdown

GH-138681 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Sep 8, 2025
@AA-Turner
AA-Turner deleted the docs/refwarn/datamodel branch September 8, 2025 19:51
hugovk pushed a commit that referenced this pull request Sep 9, 2025
@miss-islington@AA-Turner
[3.14]gh-101100: Resolve reference warnings in reference/ (GH-138418) (
dee3428
#138680)
gh-101100: Resolve reference warnings in reference/ (GH-138418)
(cherry picked from commit 6831634)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@AA-Turner@lkollar
pythongh-101100: Resolve reference warnings in reference/ (python#138418
db40d60
)
pablogsal pushed a commit that referenced this pull request Feb 15, 2026
@miss-islington@AA-Turner@StanFromIreland
[3.13]gh-101100: Resolve reference warnings in reference/ (GH-138418) (
e1dbe22
#138681)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <stan@ulbrych.org>
@encukouencukou mentioned this pull request May 13, 2026
Merged
encukou added a commit that referenced this pull request May 14, 2026
@encukou
Link to existing rules in compound_stmts.rst (GH-149811)
c375292
In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)
Replace the names with ones that appear in docs:
- `star_named_expression` in the grammar corresponds to
`flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
`flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
`assignment_expression` in the docs
Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
This was referenced May 14, 2026
Merged
Merged
Merged
encukou added a commit that referenced this pull request May 14, 2026
@miss-islington@encukou
[3.15] Link to existing rules in compound_stmts.rst (GH-149811) (GH-1…
451f06b
…49836)
Link to existing rules in compound_stmts.rst (GH-149811)
In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)
Replace the names with ones that appear in docs:
- `star_named_expression` in the grammar corresponds to
`flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
`flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
`assignment_expression` in the docs
Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2026
@miss-islington@encukou
[3.14] Link to existing rules in compound_stmts.rst (GH-149811) (GH-1…
9a1f30f
…49837)
Link to existing rules in compound_stmts.rst (GH-149811)
In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)
Replace the names with ones that appear in docs:
- `star_named_expression` in the grammar corresponds to
`flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
`flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
`assignment_expression` in the docs
Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2026
@miss-islington@encukou
[3.13] Link to existing rules in compound_stmts.rst (GH-149811) (GH-1…
4da3e91
…49838)
Link to existing rules in compound_stmts.rst (GH-149811)
In gh-138418, `!` was added to links to rules that don't exist in
the docs, in order to silence broken link warnings.
However, productionlist doesn't parse the `!`, which ends up in
the rendered documentation. (It's possible that gh-127835 broke
the `!` support.)
Replace the names with ones that appear in docs:
- `star_named_expression` in the grammar corresponds to
`flexible_expression` in the docs
- `star_named_expressions` in the grammar corresponds to
`flexible_expression_list` in the docs
- `named_expression` in the grammar corresponds to
`assignment_expression` in the docs
Having two sets of names isn't great of course. Consolidating them
is tracked in (subissues of) gh-127833.
(cherry picked from commit c375292)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk