Skip to content

gh-116738: test dbm.gnu module on FT Python build - #138467

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
yoney:ft_gdbm
Oct 12, 2025
Merged

gh-116738: test dbm.gnu module on FT Python build#138467
kumaraditya303 merged 2 commits into
python:mainfrom
yoney:ft_gdbm

Conversation

@yoney

@yoneyyoney commented Sep 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

#132749 added critical sections to the gnu.dbm object. This PR introduces multi-threaded tests for the dbm.gnu module.

cc: @mpage@colesbury@Yhg1s

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Sep 3, 2025
@bedevere-appbedevere-appBot mentioned this pull request Sep 3, 2025
Open
@yoney
yoney marked this pull request as ready for review September 3, 2025 18:15
@kumaraditya303kumaraditya303 changed the title gh-116738: Test mdb.gnu module on FT Python buildgh-116738: test dbm.gnu module on FT Python buildOct 2, 2025
@kumaraditya303kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Oct 11, 2025
kumaraditya303
kumaraditya303 reviewed Oct 11, 2025
View reviewed changes
Comment threadLib/test/test_free_threading/test_dbm_gnu.py Outdated
@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@bedevere-bot

bedevere-bot commented Oct 12, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9a1c8ae 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138467%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@kumaraditya303
kumaraditya303 merged commit a18843d into python:mainOct 12, 2025
110 of 114 checks passed
@miss-islington-app

miss-islington-appBot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@yoney@miss-islington
pythongh-116738: testdbm.gnumodule on FT Python build (pythonGH-1…
916066c
…38467)
(cherry picked from commit a18843d)
Co-authored-by: Alper <alperyoney@fb.com>
@bedevere-app

bedevere-appBot commented Oct 12, 2025

Copy link
Copy Markdown

GH-139987 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 12, 2025
@miss-islington@yoney
[3.14]gh-116738: testdbm.gnumodule on FT Python build (GH-138467) (
6d6d02a
#139987)
gh-116738: test `dbm.gnu` module on FT Python build (GH-138467)
(cherry picked from commit a18843d)
Co-authored-by: Alper <alperyoney@fb.com>
@yoney
yoney deleted the ft_gdbm branch October 19, 2025 03:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@colesburycolesburyAwaiting requested review from colesbury
@Yhg1sYhg1sAwaiting requested review from Yhg1s
@mpagempageAwaiting requested review from mpage

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoney@bedevere-bot@kumaraditya303@mpage