Skip to content

gh-135755: Make Py_TAIL_CALL_INTERP macro private - #138981

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:private_tail_cail
Sep 18, 2025
Merged

gh-135755: Make Py_TAIL_CALL_INTERP macro private#138981
vstinner merged 1 commit into
python:mainfrom
vstinner:private_tail_cail

Conversation

@vstinner

@vstinnervstinner commented Sep 16, 2025

Copy link
Copy Markdown
Member

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.
@vstinner

Copy link
Copy Markdown
MemberAuthor

@Fidget-Spinner: I blindly replaced Py_TAIL_CALL_INTERP text with _Py_TAIL_CALL_INTERP. I didn't test my change.

@Fidget-Spinner

Copy link
Copy Markdown
Member

Thanks. I'll approve once CI passes.

@vstinner

Copy link
Copy Markdown
MemberAuthor

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

@Fidget-Spinner

Copy link
Copy Markdown
Member

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

Don't worry, we have CI for the tail calling interpreter on most platforms, so you can just let it run :)

@vstinner

Copy link
Copy Markdown
MemberAuthor

Ping @Fidget-Spinner

@vstinner

Copy link
Copy Markdown
MemberAuthor

@hugovk: This change mostly/only makes sense if it's backported to 3.14. Would you accept this late C API change in 3.14? It makes the macro private.

@vstinner

Copy link
Copy Markdown
MemberAuthor

Maybe it's ok to leave the macro in 3.14 and remove it in 3.15. No one should rely on this macro :-)

@vstinner
vstinner merged commit 6504f20 into python:mainSep 18, 2025
82 checks passed
@vstinner
vstinner deleted the private_tail_cail branch September 18, 2025 12:33
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6504f20ccedf0b27275327e72698dee5f0c75ba8 3.14

vstinner added a commit to vstinner/cpython that referenced this pull request Sep 18, 2025
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.
(cherry picked from commit 6504f20)
@bedevere-app

Copy link
Copy Markdown

GH-139120 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
@vstinner

Copy link
Copy Markdown
MemberAuthor

@Fidget-Spinner suggested me to merge this change in the main branch, so I did it :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@Fidget-Spinner@corona10@hugovk