Skip to content

gh-135729: Store reference to globals in Interpreter._decref - #139104

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:fix-interp-del
Sep 18, 2025
Merged

gh-135729: Store reference to globals in Interpreter._decref#139104
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:fix-interp-del

Conversation

@ZeroIntensity

@ZeroIntensityZeroIntensity commented Sep 18, 2025

Copy link
Copy Markdown
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor formatting recommendation, LGTM.

Comment threadLib/concurrent/interpreters/__init__.py Outdated
@github-project-automationgithub-project-automationBot moved this from Todo to In Progress in SprintSep 18, 2025
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ZeroIntensity
ZeroIntensity enabled auto-merge (squash) September 18, 2025 10:57
@ZeroIntensityZeroIntensity added the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
@ZeroIntensity
ZeroIntensity merged commit 571210b into python:mainSep 18, 2025
47 checks passed
@ZeroIntensity
ZeroIntensity deleted the fix-interp-del branch September 18, 2025 11:17
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in SprintSep 18, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
…ythonGH-139104)
(cherry picked from commit 571210b)
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-139112 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
ZeroIntensity added a commit that referenced this pull request Oct 7, 2025
…GH-139104) (GH-139112)
* gh-135729: Store reference to globals in `Interpreter._decref` (GH-139104)
(cherry picked from commit 571210b)
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity@ericsnowcurrently