Uh oh!
There was an error while loading. Please reload this page.
gh-126016: Remove bad assertion in PyThreadState_Clear - #139158
Merged
Conversation
PyThreadState_ClearPyThreadState_Clearericsnowcurrently
approved these changes
Sep 19, 2025
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks for doing this.
ZeroIntensity
enabled auto-merge (squash)
September 19, 2025 12:06
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
_interpretersmodule, we usePyEval_EvalCodeto run Python code in another interpreter. However, when the process receives aKeyboardInterrupt,PyEval_EvalCodewill jump straight to finalization rather than returning. This prevents us from cleaning up and marking the thread as "not running main", which triggers an assertion inPyThreadState_Clearon debug builds. Since everything else works as intended, remove that assertion.