Skip to content

gh-138122: Allow to filter by thread in tachyon's flamegraph - #139216

Merged
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-138709-4
Sep 25, 2025
Merged

gh-138122: Allow to filter by thread in tachyon's flamegraph#139216
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-138709-4

Conversation

@pablogsal

@pablogsalpablogsal commented Sep 21, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Sep 21, 2025
Open
@pablogsal

pablogsal commented Sep 21, 2025

Copy link
Copy Markdown
MemberAuthor

CC: @lkollar

lkollar
lkollar reviewed Sep 22, 2025
View reviewed changes

@lkollarlkollar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of related: I'm realising that the help text of --mode doesn't display the default. We could fix that here as well.

Comment threadLib/profiling/sampling/flamegraph.js Outdated
@pablogsal
pablogsal merged commit bc7b511 into python:mainSep 25, 2025
43 checks passed
@pablogsal
pablogsal deleted the gh-138709-4 branch September 25, 2025 14:34
ivonastojanovic added a commit to ivonastojanovic/cpython that referenced this pull request Sep 26, 2025
@ivonastojanovic
fixup!pythongh-138122: Allow to filter by thread in tachyon's flameg…
2b48c12
…raph (python#139216)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lkollarlkollarlkollar left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal@lkollar