Skip to content

gh-138489: Add missing build-details.json step for building wasm - #139302

Merged
FFY00 merged 3 commits into
python:mainfrom
ulagbulag:fix/wasm-build-details.json
Oct 4, 2025
Merged

gh-138489: Add missing build-details.json step for building wasm#139302
FFY00 merged 3 commits into
python:mainfrom
ulagbulag:fix/wasm-build-details.json

Conversation

@HoKim98

@HoKim98HoKim98 commented Sep 24, 2025•
edited by picnixz
Loading

Copy link
Copy Markdown
Contributor

Hello, this PR just adds a missing build-details.json build step on WASM ecosystems (e.g. WASI).

When cross-compiling for WASI by build_wasm or build_emscripten, the build-details.json step is now included in the build process, just like with native builds.

This fixes the libinstall task which requires the build-details.json file during the process.

@HoKim98
fix: add missing build-details.json step for building wasm
053a8c2
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
@bedevere-app

bedevere-appBot commented Sep 24, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot

python-cla-botBot commented Sep 24, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@HoKim98HoKim98 changed the title Add missing build-details.json step for building wasmgh-139302: Add missing build-details.json step for building wasmSep 24, 2025
@picnixzpicnixz changed the title gh-139302: Add missing build-details.json step for building wasmgh-138489: Add missing build-details.json step for building wasmSep 24, 2025
@bedevere-appbedevere-appBot mentioned this pull request Sep 24, 2025
Open
@HoKim98
HoKim98 marked this pull request as ready for review September 24, 2025 14:03
@AA-Turner

AA-Turner commented Sep 24, 2025

Copy link
Copy Markdown
Member

Sorry, it's far too easy to click the 'copilot' button, this was absolutely not my intent!

A

@pythonpython deleted a comment from CopilotAISep 24, 2025
AA-Turner
AA-Turner reviewed Sep 24, 2025
View reviewed changes
Comment threadMakefile.pre.in Outdated
@HoKim98@AA-Turner
Update Makefile.pre.in
6bbad6d
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@HoKim98
HoKim98force-pushed the fix/wasm-build-details.json branch from f9a947b to 6bbad6dCompareSeptember 24, 2025 14:14

This comment was marked as spam.

Sign in to view

@emmatyping

emmatyping commented Sep 24, 2025

Copy link
Copy Markdown
Member

Confirmed locally this also fixes #137878

$ wasmtime--dir/opt/wasi-python//opt/wasi-python/bin/python3.wasmPython3.15.0a0 (heads/fix/wasm-build-details.json-dirty:6bbad6d6cc2, Sep242025, 10:33:33) [Clang19.1.5-wasi-sdk (https://github.com/llvm/llvm-projectab4b5a2db582958af1eonwasiType"help", "copyright", "credits"or"license"formoreinformation.
warning: can't use pyrepl: No module named 'termios'
>>>importmath>>>math.pi3.141592653589793

emmatyping
emmatyping approved these changes Sep 24, 2025
View reviewed changes

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me.

FFY00
FFY00 approved these changes Oct 4, 2025
View reviewed changes

@FFY00FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HoKim98 😊

@FFY00
FFY00 merged commit db53ca3 into python:mainOct 4, 2025
45 checks passed
@AA-TurnerAA-Turner added the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@miss-islington-app

miss-islington-appBot commented Oct 4, 2025

Copy link
Copy Markdown

Thanks @HoKim98 for the PR, and @FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2025
@HoKim98@AA-Turner@miss-islington
pythongh-138489: Add missingbuild-details.jsonstep for building w…
ff0c6ac
…asm (pythonGH-139302)
* fix: add missing `build-details.json` step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* pythongh-138489: Add missing build-details.json step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* Update Makefile.pre.in
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
---------
(cherry picked from commit db53ca3)
Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Oct 4, 2025

Copy link
Copy Markdown

GH-139557 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@AA-Turner

AA-Turner commented Oct 4, 2025

Copy link
Copy Markdown
Member

I think it's worth backporting this, but it's not critical that this goes into 3.14.0. What do we think?

A

@FFY00FFY00 added the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2025
@HoKim98@AA-Turner@miss-islington
pythongh-138489: Add missingbuild-details.jsonstep for building w…
8cbc4bb
…asm (pythonGH-139302)
* fix: add missing `build-details.json` step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* pythongh-138489: Add missing build-details.json step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* Update Makefile.pre.in
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
---------
(cherry picked from commit db53ca3)
Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@AA-Turner

AA-Turner commented Oct 4, 2025

Copy link
Copy Markdown
Member

Backport PR already created at GH-139557, miss-islington doesn't appear to recognise this.

A

danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@HoKim98@AA-Turner@danigm
pythongh-138489: Add missingbuild-details.jsonstep for building w…
9c81b64
…asm (python#139302)
* fix: add missing `build-details.json` step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* pythongh-138489: Add missing build-details.json step for building wasm
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
* Update Makefile.pre.in
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
---------
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington@HoKim98@AA-Turner
[3.14]gh-138489: Add missingbuild-details.jsonstep for building …
77b4ed2
…wasm (GH-139302) (GH-139557)
(cherry picked from commit db53ca3)
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovkhugovk removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@emmatypingemmatypingemmatyping approved these changes
@FFY00FFY00FFY00 approved these changes
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@FFY00FFY00

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HoKim98@AA-Turner@emmatyping@FFY00@hugovk