Skip to content

gh-90949: amend GH-139234 in prevision of future mitigation API - #139366

Merged
picnixz merged 3 commits into
python:mainfrom
picnixz:feat/xml/post-139234
Sep 26, 2025
Merged

gh-90949: amend GH-139234 in prevision of future mitigation API#139366
picnixz merged 3 commits into
python:mainfrom
picnixz:feat/xml/post-139234

Conversation

@picnixz

@picnixzpicnixz commented Sep 26, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

There were some typos that slipped under both @hartwork's and my radar and some functions that could be made more generic and used by the next PR.

📚 Documentation preview 📚: https://cpython-previews--139366.org.readthedocs.build/

@bedevere-appbedevere-appBot mentioned this pull request Sep 26, 2025
Open
This was referenced Sep 26, 2025
Merged
Merged
hartwork
hartwork approved these changes Sep 26, 2025
View reviewed changes

@hartworkhartwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@picnixz looks alright with me 👍

@picnixz

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Oh thank you for the review. I pinged you on the wrong PR but you saw this one. Thanks!

@picnixz
picnixz enabled auto-merge (squash) September 26, 2025 16:36
@picnixz

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@picnixzpicnixz mentioned this pull request Sep 26, 2025
Merged
@hartwork

hartwork commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@picnixz sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker. Is that what you meant?

@picnixz

picnixz commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker

yes, I don't know if cherry-picker can do multiple cherry-picks actually

@picnixz

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Mmh, TSAN is taking an incredibly long time.

@picnixz
picnixz merged commit 68a1778 into python:mainSep 26, 2025
81 of 83 checks passed
@picnixz
picnixz deleted the feat/xml/post-139234 branch September 26, 2025 18:16
hartwork pushed a commit to hartwork/cpython that referenced this pull request Sep 26, 2025
@picnixz@hartwork
pythongh-90949: amendpythonGH-139234in prevision of future mitigati…
b235056
…on API (python#139366)
Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
(cherry picked from commit 68a1778)
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 28, 2025
@picnixz
pythongh-90949: amendpythonGH-139234in prevision of future mitigati…
b52fc88
…on API (python#139366)
Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
@picnixz@hartwork
pythongh-90949: amendpythonGH-139234in prevision of future mitigati…
a5d026a
…on API (python#139366)
Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
@picnixz@hartwork
pythongh-90949: amendpythonGH-139234in prevision of future mitigati…
5680561
…on API (python#139366)
Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 3, 2025
@picnixz@hartwork
pythongh-90949: amendpythonGH-139234in prevision of future mitigati…
6ae7665
…on API (python#139366)
Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
(cherry picked from commit 68a1778)
@hartworkhartwork mentioned this pull request Oct 5, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
1 more reviewer
@hartworkhartworkhartwork approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@hartwork