Skip to content

gh-92266: Update pre-commit - #139411

Merged
hugovk merged 4 commits into
python:mainfrom
hugovk:pre-commit-remove-tabs
Oct 1, 2025
Merged

gh-92266: Update pre-commit#139411
hugovk merged 4 commits into
python:mainfrom
hugovk:pre-commit-remove-tabs

Conversation

@hugovk

@hugovkhugovk commented Sep 29, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Sep 29, 2025
@bedevere-appbedevere-appBot mentioned this pull request Sep 29, 2025
Closed
itamaro
itamaro approved these changes Sep 30, 2025
View reviewed changes

@itamaroitamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the attached issue relevant to this PR?

@hugovk

hugovk commented Sep 30, 2025

Copy link
Copy Markdown
MemberAuthor

Partially, that issue was the trigger for updating because Tools/c-analyzer/cpython/_parser.py was excluded from remove-tabs and #92266 (comment) notes it no longer has tabs.

But we can also skip-issue here if you like.

@itamaro

itamaro commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

But we can also skip-issue here if you like.

Either would be fine

@hugovk
hugovk merged commit 800d856 into python:mainOct 1, 2025
45 checks passed
@hugovk
hugovk deleted the pre-commit-remove-tabs branch October 1, 2025 05:40
@miss-islington-app

miss-islington-appBot commented Oct 1, 2025

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2025
@hugovk@miss-islington
pythongh-92266: Update pre-commit (pythonGH-139411)
bb18c88
(cherry picked from commit 800d856)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@miss-islington-app

miss-islington-appBot commented Oct 1, 2025

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 800d856bc78ec0431450361c346bc1e5996f6624 3.13

@bedevere-app

bedevere-appBot commented Oct 1, 2025

Copy link
Copy Markdown

GH-139466 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Oct 1, 2025
hugovk added a commit that referenced this pull request Oct 8, 2025
@miss-islington@hugovk
[3.14]gh-92266: Update pre-commit (GH-139411) (#139466)
297157d
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139760 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 8, 2025
@hugovk
[3.13]pythongh-92266: Update pre-commit (pythonGH-139411)
fea7b7c
(cherry picked from commit 800d856)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Oct 27, 2025
@hugovk
[3.13]gh-92266: Update pre-commit (GH-139411) (#139760)
2d29aa2
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaroitamaroitamaro approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

Assignees

@hugovkhugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@itamaro@AlexWaygood@StanFromIreland