Uh oh!
There was an error while loading. Please reload this page.
gh-139322: Create test_os package - #139453
Conversation
* Move test_posix.py and test_os.py to Lib/test/test_os/ * Split Windows specific test cases to a new test_windows.py file.
vstinner
commented
Sep 30, 2025
@serhiy-storchaka: Here is a simpler approach which only creates |
vstinner
commented
Oct 1, 2025
Ooops, I forgot git add :-) Fixed. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Win32ErrorTests may be removed if all its tests are duplicated in other places for all platforms.
| from .utils import create_file | ||
| class Win32ErrorTests(unittest.TestCase): |
There was a problem hiding this comment.
Originally, these tests were for WindowsError. But now OSError is raised on all platforms. These tests are no longer Windows specific, and most likely are duplicated in other parts.
Please check that all these functions are already tested with non-existing file (and mkdir() with an existing file). Then they can be deleted.
Merged, thanks for the review.
Good catch! I created #139477 to remove |
Uh oh!
There was an error while loading. Please reload this page.