Skip to content

gh-63016: Add flags parameter on mmap.flush - #139553

Merged
vstinner merged 11 commits into
python:mainfrom
aisk:mmap-flush-flags
Dec 27, 2025
Merged

gh-63016: Add flags parameter on mmap.flush#139553
vstinner merged 11 commits into
python:mainfrom
aisk:mmap-flush-flags

Conversation

@aisk

@aiskaisk commented Oct 4, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 4, 2025
Closed
@aisk

aisk commented Oct 4, 2025

Copy link
Copy Markdown
MemberAuthor

I noticed a PR #139237 to migrate the mmap module to use AC. We should wait for it to be merged before continue the work.

@aisk
aisk marked this pull request as draft October 4, 2025 12:26
@aisk
aisk marked this pull request as ready for review October 11, 2025 13:00
@aisk

aisk commented Oct 11, 2025

Copy link
Copy Markdown
MemberAuthor

Since #139237 was merged, I rebased the branch and now it's ready for review.

vstinner
vstinner reviewed Dec 23, 2025
View reviewed changes
Comment threadModules/mmapmodule.c
Comment threadLib/test/test_mmap.py Outdated
Comment threadLib/test/test_mmap.py
vstinner
vstinner approved these changes Dec 24, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please just update the doc (see my comment).

Comment threadDoc/library/mmap.rst Outdated
@aisk@vstinner
Update Doc/library/mmap.rst
a471614
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner

vstinner commented Dec 27, 2025

Copy link
Copy Markdown
Member

Oh, you have to run make clinic to update Argument Clinic.

@aisk

aisk commented Dec 27, 2025

Copy link
Copy Markdown
MemberAuthor

@vstinner Sorry I forgot check the CI status, updated!

@vstinner
vstinner enabled auto-merge (squash) December 27, 2025 10:10
@vstinner
vstinner merged commit 1af21ea into python:mainDec 27, 2025
46 checks passed
@aisk
aisk deleted the mmap-flush-flags branch December 27, 2025 10:45
@picnixz

picnixz commented Dec 27, 2025

Copy link
Copy Markdown
Member

This broke some build bots: https://buildbot.python.org/#/builders/1232/builds/7610

picnixz added a commit that referenced this pull request Jan 1, 2026
@picnixz
Amend NEWS entries for PRsGH-139553andGH-142790(#143329)
422ca07
@vstinner

vstinner commented Jan 7, 2026

Copy link
Copy Markdown
Member

This broke some build bots: https://buildbot.python.org/#/builders/1232/builds/7610

It has been fixed by #143230.

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@aisk@vstinner@thunder-coding
pythongh-63016: Add flags parameter on mmap.flush (python#139553)
3c8cd36
Co-authored-by: Victor Stinner <vstinner@python.org>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@picnixz@thunder-coding
Amend NEWS entries for PRspythonGH-139553andpythonGH-142790(pytho…
07d61b6
…n#143329)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aisk@vstinner@picnixz@nazeerali4325-commits