Skip to content

gh-139588: Add sphinx.ext.imgconvert to support SVG on Latex - #139635

Closed
adorilson wants to merge 1 commit into
python:mainfrom
adorilson:gh139588_add_svg_support_to_build_pdf
Closed

gh-139588: Add sphinx.ext.imgconvert to support SVG on Latex#139635
adorilson wants to merge 1 commit into
python:mainfrom
adorilson:gh139588_add_svg_support_to_build_pdf

Conversation

@adorilson

@adorilsonadorilson commented Oct 6, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

gh-139588: Add sphinx.ext.imgconvert to support SVG on Latex

It converts the SVG to PNG for LaTeX, but keeps SVG for HTML.

📚 Documentation preview 📚: https://cpython-previews--139635.org.readthedocs.build/

@StanFromIrelandStanFromIreland changed the title Doc: Add sphinx.ext.imgconvert to support SVG on Latexgh-139588: Add sphinx.ext.imgconvert to support SVG on LatexOct 6, 2025
@bedevere-appbedevere-appBot mentioned this pull request Oct 6, 2025
Closed
@StanFromIreland

StanFromIreland commented Oct 6, 2025

Copy link
Copy Markdown
Member

In the future, can you please add the issue number to the title like you have in the description.

@m-aciekm-aciek mentioned this pull request Oct 15, 2025
Closed
@m-aciek

m-aciek commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

@adorilson could you please share a screenshot of the PDF page with the diagram rendered?

@adorilson

adorilson commented Oct 16, 2025

Copy link
Copy Markdown
ContributorAuthor

@adorilson could you please share a screenshot of the PDF page with the diagram rendered?

44% zoom
image

100% zoom

image

@StanFromIreland

StanFromIreland commented Oct 16, 2025

Copy link
Copy Markdown
Member

That looks like a significant degradation of image quality, although it could be due to GH’s compression, can you please confirm?

@adorilson

adorilson commented Oct 16, 2025

Copy link
Copy Markdown
ContributorAuthor

That looks like a significant degradation of image quality, although it could be due to GH’s compression, can you please confirm?

Yes. There is a significant degradation of image quality.

I think it is the cons put by @m-aciek on the options table: #139588 (comment)

@m-aciekm-aciek mentioned this pull request Oct 19, 2025
Closed
@m-aciekm-aciek mentioned this pull request Nov 2, 2025
Closed
This was referenced Feb 28, 2026
Closed
Closed
Closed
@StanFromIreland

StanFromIreland commented Mar 19, 2026

Copy link
Copy Markdown
Member

This was fixed by #145480.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adorilson@StanFromIreland@m-aciek@nazeerali4325-commits