GH-139727: Add --enable-stackref-debug flag to build.bat to enable Py_STACKREF_DEBUG build on Windows

[sergey-miryanov]

Working on #139384 I discovered that build.bat does not have easy way to enable Py_STACKREF_DEBUG build.

• Issue: Add flags to build with Py_STACKREF_DEBUG enabled on Windows #139727

[sergey-miryanov]

@zooba Could you please take a look? Is this a right way to add some specific flags to builds?

[zooba]

Looks fine, does the CLI argument match the equivalent option to configure?

[efimov-mikhail]

Looks fine, does the CLI argument match the equivalent option to configure?

Actually, there's no such option to configure.
I'd like to add this in some future PR, I've already tested those changes locally.

[zooba]

Would it fit in? I mainly want the same option, and the configure maintainers are more opinionated about it, so let's make sure we pick a name that they'll be happy with.

[efimov-mikhail]

I'm thinking about the following options:

--enable-stackref-debug[=no|yes|closed]

And this logic on it:

case $enable_stackref_debug in
no) stackref_debug_flags="" ;;
yes) stackref_debug_flags="-DPy_STACKREF_DEBUG" ;;
closed) stackref_debug_flags="-DPy_STACKREF_DEBUG -DPy_STACKREF_CLOSE_DEBUG" ;;

But at the time it's only my suggestion.

[sergey-miryanov]

I'm OK with @efimov-mikhail suggestion. I'm also open to updating this PR accordingly.

[zooba]

Hmm, except we don't really have any options with values. Let's just rename to --enable-stackref-debug and not support =<no|yes|etc.> in build.bat - that should be the same as the other options we've got.

If the eventual configure argument gets its name changed, we can update to match. The build.bat interface isn't really public API, so it can change more easily than Python.

[sergey-miryanov]

@zooba I renamed it. Could you please take a look?

[zooba]

Looks good to me now. Anything else you need to do, or is this good to merge?

[sergey-miryanov]

It is good to merge.

[sergey-miryanov]

Thanks!