Skip to content

gh-84232: Fix pydoc docs.python.org link generation - #139995

Merged
hugovk merged 7 commits into
python:mainfrom
StanFromIreland:pydoc-link
Dec 23, 2025
Merged

gh-84232: Fix pydoc docs.python.org link generation#139995
hugovk merged 7 commits into
python:mainfrom
StanFromIreland:pydoc-link

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Oct 12, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 12, 2025
Closed
@StanFromIreland

StanFromIreland commented Oct 12, 2025

Copy link
Copy Markdown
MemberAuthor

Requesting Serhiy per experts list.

@StanFromIreland

StanFromIreland commented Oct 12, 2025

Copy link
Copy Markdown
MemberAuthor

UBSan failure is unrelated.

@StanFromIreland

StanFromIreland commented Oct 13, 2025

Copy link
Copy Markdown
MemberAuthor

@picnixz Thanks for the helpful reviews on the (other) pydoc PR, I also happen to have this one if you are interested, I'd appreciate your thoughts.

serhiy-storchaka
serhiy-storchaka reviewed Oct 13, 2025
View reviewed changes
Comment threadLib/pydoc.py Outdated
@StanFromIrelandStanFromIreland changed the title gh-139971: Fix pydoc docs.python.org link generationgh-84232: Fix pydoc docs.python.org link generationOct 13, 2025
@bedevere-appbedevere-appBot mentioned this pull request Oct 13, 2025
Closed
@StanFromIrelandStanFromIreland mentioned this pull request Oct 13, 2025
Closed
merwok
merwok reviewed Dec 15, 2025
View reviewed changes
Comment threadDoc/tools/extensions/pydoc_topics.py
@merwok

merwok commented Dec 15, 2025

Copy link
Copy Markdown
Member

I’m ready to review after conflicts are fixed to get this merged!

@merwok

merwok commented Dec 15, 2025

Copy link
Copy Markdown
Member

I’m not adding the backport labels as the list of modules has differences between versions, and there is a manual step to generate the pydoc data file.

@StanFromIreland

StanFromIreland commented Dec 15, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

a manual step

Yes and no, the script is run during the release process anyway, there is no additional work for RMs:-)

@hugovk
hugovk merged commit f9704f1 into python:mainDec 23, 2025
87 of 89 checks passed
@StanFromIreland
StanFromIreland deleted the pydoc-link branch December 23, 2025 09:20
@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 23, 2025
@miss-islington-app

miss-islington-appBot commented Dec 23, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Dec 23, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2025
@StanFromIreland@merwok@miss-islington
pythongh-84232: Fixpydocdocs.python.org link generation (pythonGH…
4f9ddba
…-139995)
(cherry picked from commit f9704f1)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
@miss-islington-app

miss-islington-appBot commented Dec 23, 2025

Copy link
Copy Markdown

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f9704f1d84044e46b94f2e4854dae43c1adaa7f1 3.13

@bedevere-app

bedevere-appBot commented Dec 23, 2025

Copy link
Copy Markdown

GH-143098 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Dec 23, 2025
@bedevere-app

bedevere-appBot commented Dec 23, 2025

Copy link
Copy Markdown

GH-143099 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Dec 23, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Dec 23, 2025
@StanFromIreland@merwok@hugovk
[3.13]pythongh-84232: Fixpydocdocs.python.org link generation (p…
08f473b
…ythonGH-139995)
(cherry picked from commit f9704f1)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
hugovk pushed a commit that referenced this pull request Dec 23, 2025
@miss-islington@StanFromIreland@merwok
[3.14]gh-84232: Fixpydocdocs.python.org link generation (GH-139995…
a007e95
…) (#143098)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
hugovk added a commit that referenced this pull request Dec 23, 2025
@hugovk@StanFromIreland@merwok
[3.13]gh-84232: Fixpydocdocs.python.org link generation (GH-139995…
7dc6acc
…) (#143099)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
@hugovkhugovk mentioned this pull request Jan 20, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka
@zwarezwareAwaiting requested review from zware
@merwokmerwokAwaiting requested review from merwok

Assignees

@hugovkhugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StanFromIreland@merwok@hugovk@serhiy-storchaka@nazeerali4325-commits