Skip to content

gh-139817: Fix refleak in TypeAliasType(qualname=non_string) - #140197

Merged
encukou merged 2 commits into
python:mainfrom
encukou:gh-139817-leak
Oct 16, 2025
Merged

gh-139817: Fix refleak in TypeAliasType(qualname=non_string)#140197
encukou merged 2 commits into
python:mainfrom
encukou:gh-139817-leak

Conversation

@encukou

@encukouencukou commented Oct 16, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 16, 2025
Closed
@encukou

encukou commented Oct 16, 2025

Copy link
Copy Markdown
MemberAuthor

!buildbot AMD64.Fedora.Stable.Refleaks

@bedevere-bot

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 8c46640 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140197%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Fedora.Stable.Refleaks

The builders matched are:

  • AMD64 Fedora Stable Refleaks PR

efimov-mikhail
efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

@efimov-mikhailefimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've missed this, sorry.

efimov-mikhail
efimov-mikhail reviewed Oct 16, 2025
View reviewed changes
Comment threadObjects/typevarobject.c
Py_DECREF(module);
return NULL;
}
}

@efimov-mikhailefimov-mikhailOct 16, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).

@encukou
encukou enabled auto-merge (squash) October 16, 2025 11:00
efimov-mikhail
efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

@efimov-mikhailefimov-mikhail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested for the refleak locally, it's gone.

@encukou
encukou merged commit ea4cc58 into python:mainOct 16, 2025
43 checks passed
@encukouencukou mentioned this pull request Oct 16, 2025
Merged
@encukou
encukou deleted the gh-139817-leak branch October 17, 2025 10:30
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou@StanFromIreland
pythongh-139817: Fix refleak in TypeAliasType(qualname=non_string) (p…
fe4b7b7
…ythonGH-140197)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhailefimov-mikhailefimov-mikhail approved these changes
@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@bedevere-bot@efimov-mikhail