Skip to content

gh-140138: NOGIL: add atomic owner refcount to PyInterpreterState; finalize on last tstate - #140224

Closed
ashm-dev wants to merge 11 commits into
python:mainfrom
ashm-dev:gh-140138
Closed

gh-140138: NOGIL: add atomic owner refcount to PyInterpreterState; finalize on last tstate#140224
ashm-dev wants to merge 11 commits into
python:mainfrom
ashm-dev:gh-140138

Conversation

@ashm-dev

@ashm-devashm-dev commented Oct 16, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Oct 16, 2025
Closed
@ashm-dev

ashm-dev commented Oct 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Changes made on top of the previous fix from PR

ZeroIntensity
ZeroIntensity reviewed Oct 16, 2025
View reviewed changes
Comment threadInclude/internal/pycore_interp_structs.h Outdated
Comment threadMisc/NEWS.d/next/Core_and_Builtins/2025-10-16-20-06-33.gh-issue-140138.a_fhrh.rst Outdated
Comment threadPython/pystate.c Outdated
Comment threadPython/pystate.c Outdated
Comment threadPython/pystate.c Outdated
Comment threadPython/pystate.c Outdated
ZeroIntensity
ZeroIntensity reviewed Oct 16, 2025
View reviewed changes

@ZeroIntensityZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this PR looks good if we decide to fix this, but I'm worried about whether this is even a bug in the first place. See my comment on the issue. Please let me know if I missed something in my analysis.

@ashm-dev
fix tsan
115e4d2
@ashm-dev
add blurb
b58d4a1
@ashm-dev
Reorder and add _owners field
55b5fe4
Move the `_owners` field to be after `finalizing` and add it back to the
struct. It was removed in a previous commit and is needed.
@ashm-dev
Fix typo in interpreter owner atomic variable
2aba8ba
Fixes a typo where the atomic variable `_owners` was incorrectly named
and should have been `owners`.
@ashm-dev
Fix news
2690fac
@ashm-dev
Rename interpreter cleanup functions
e6ff33e
Rename functions to be more descriptive of their actions.
@ashm-dev
Refactor interpreter cleanup
47e51d7
Move the cleanup logic into PyInterpreterState_Delete and remove the
now-unused helper function.
@ashm-dev
Rename _owners to owners in interp struct
37ccb72
The field name was inconsistent with other usages.
@ashm-dev
fix
e5c1336
@ashm-dev
Stop setting interp->finalizing
d08a093
@ashm-dev

ashm-dev commented Oct 19, 2025

Copy link
Copy Markdown
ContributorAuthor

@ZeroIntensity this PR necessary or is it better to close it?

@ZeroIntensity

ZeroIntensity commented Oct 19, 2025

Copy link
Copy Markdown
Member

I don't think this PR is necessary.

@ashm-dev
ashm-dev deleted the gh-140138 branch October 19, 2025 16:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

awaiting reviewDO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashm-dev@ZeroIntensity