Skip to content

gh-76007: Deprecate __version__ attribute in decimal - #140302

Merged
vstinner merged 10 commits into
python:mainfrom
StanFromIreland:decimal-version
Oct 26, 2025
Merged

gh-76007: Deprecate __version__ attribute in decimal#140302
vstinner merged 10 commits into
python:mainfrom
StanFromIreland:decimal-version

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Oct 18, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 18, 2025
Closed
@StanFromIreland
StanFromIreland marked this pull request as draft October 18, 2025 14:52
@StanFromIreland
StanFromIreland marked this pull request as ready for review October 18, 2025 15:17
vstinner
vstinner reviewed Oct 18, 2025
View reviewed changes
Comment threadModules/_decimal/_decimal.c Outdated
@vstinner

vstinner commented Oct 18, 2025

Copy link
Copy Markdown
Member

cc @skirpichev@picnixz

@StanFromIreland@vstinner
Correct version number
0a2a9fb
Co-authored-by: Victor Stinner <vstinner@python.org>
skirpichev
skirpichev reviewed Oct 18, 2025
View reviewed changes
Comment threadDoc/library/decimal.rst Outdated
Comment threadLib/_pydecimal.py Outdated
Comment threadLib/_pydecimal.py Outdated
Comment threadModules/_decimal/_decimal.c
Comment threadModules/_decimal/_decimal.c Outdated
efimov-mikhail
efimov-mikhail reviewed Oct 18, 2025
View reviewed changes
Comment threadModules/_decimal/_decimal.c Outdated
Comment threadLib/decimal.py
@merwok

merwok commented Oct 19, 2025

Copy link
Copy Markdown
Member

(Please edit the commit message when merging so that we’re not tagged forever by pushes in clones! thanks 🙂)

StanFromIrelandand others added 2 commits October 19, 2025 08:40
@StanFromIreland@skirpichev
Apply suggestions from code review
9b43d7f
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@StanFromIreland
Convert to macro
82ef916
@StanFromIreland

StanFromIreland commented Oct 19, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

(Please edit the commit message when merging so that we’re not tagged forever by pushes in clones! thanks 🙂)

Éric, all of my commits up to that point had the commit message "Commit"? I tagged you in the PR description, I don't think that should be a burden for longer than this PR is open? There is an "unsubscribe" button in the right sidebar.

skirpichev
skirpichev reviewed Oct 19, 2025
View reviewed changes
Comment threadModules/_decimal/_decimal.c Outdated
skirpichev
skirpichev approved these changes Oct 19, 2025
View reviewed changes

@skirpichevskirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo one nitpick about decimal.rst.

I'm not sure also about naming for the constant. But lets see what other people think.

Comment threadDoc/library/decimal.rst Outdated

.. versionadded:: 3.8.3

.. data:: SPEC_VERSION

@skirpichevskirpichevOct 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think that this should be moved up before "The constants in this section are only relevant for the C module." sentence of the first paragraph. Which should be also rephrased, i.e. "Following constants in <...>". Clearly, spec version is relevant for both modules.

BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?

@StanFromIrelandStanFromIrelandOct 19, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I'm not sure about naming. Maybe more verbose "DECIMAL_SPEC_VERSION"?

I have a similar sentiment, I simply used this since it was in the discussion.

@skirpichev

skirpichev commented Oct 19, 2025

Copy link
Copy Markdown
Member

all of my commits up to that point had the commit message "Commit"? I tagged you in the PR description

It seems core devs sometimes use PR descriptions for commit messages. So, it's rather a reminder for one, who will merge this pr.

hugovk
hugovk approved these changes Oct 20, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure also about naming for the constant. But lets see what other people think.

decimal.SPEC_VERSION is fine by me. Skip also suggested it at #76007 (comment).

Comment threadDoc/deprecations/pending-removal-in-3.20.rst Outdated
Comment threadDoc/whatsnew/3.15.rst Outdated
Comment threadLib/_pydecimal.py Outdated
@StanFromIreland@hugovk
Apply suggestions from code review
ba3295b
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@vstinner
vstinner merged commit 00026d1 into python:mainOct 26, 2025
45 checks passed
@vstinner

vstinner commented Oct 26, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

@StanFromIreland
StanFromIreland deleted the decimal-version branch October 26, 2025 11:06
@vstinner

vstinner commented Oct 28, 2025

Copy link
Copy Markdown
Member

Oh, importing decimal does now emit a DeprecationWarning:

$ ./python-Werror-c"import decimal"Traceback (mostrecentcalllast):
File"<string>", line1, in<module>importdecimalFile"/home/vstinner/python/main/Lib/decimal.py", line103, in<module>from_decimalimport__version__# noqa: F401^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^DeprecationWarning: '__version__'isdeprecatedandslatedforremovalinPython3.20

@vstinner

vstinner commented Oct 28, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Oh, ignore my previous comment, I forgot to run make when testing an old PR :-)

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland@vstinner
@skirpichev@hugovk
pythongh-76007: Deprecate__version__attribute indecimal(pytho…
2556dd9
…n#140302)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@skirpichevskirpichevskirpichev approved these changes
@efimov-mikhailefimov-mikhailefimov-mikhail approved these changes
@rhettingerrhettingerAwaiting requested review from rhettinger
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@StanFromIreland@vstinner@merwok@skirpichev@hugovk@efimov-mikhail