Skip to content

gh-139707: Specify winreg, msvcrt and winsound module availability in docs - #140429

Merged
encukou merged 2 commits into
python:mainfrom
StanFromIreland:winreg
Nov 10, 2025
Merged

gh-139707: Specify winreg, msvcrt and winsound module availability in docs#140429
encukou merged 2 commits into
python:mainfrom
StanFromIreland:winreg

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Oct 21, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news awaiting review labels Oct 21, 2025
@StanFromIrelandStanFromIreland changed the title Specify winreg availability in docsSpecify winreg module availability in docsOct 21, 2025
@StanFromIreland

StanFromIreland commented Oct 21, 2025

Copy link
Copy Markdown
MemberAuthor

There are a few more cases, I will add them to this PR.

@StanFromIreland
StanFromIreland marked this pull request as draft October 21, 2025 16:10
@StanFromIreland
StanFromIreland marked this pull request as ready for review October 21, 2025 16:13
@StanFromIrelandStanFromIreland changed the title Specify winreg module availability in docsSpecify winreg, msvcrt and winsound module availability in docsOct 21, 2025
@StanFromIrelandStanFromIreland changed the title Specify winreg, msvcrt and winsound module availability in docsgh-139707: Specify winreg, msvcrt and winsound module availability in docsOct 21, 2025
aisk
aisk approved these changes Nov 6, 2025
View reviewed changes
@encukou

encukou commented Nov 7, 2025

Copy link
Copy Markdown
Member

Hmm, I see these all have :platform: Windows in the header. That's a standard Sphinx option but that seems to have no effect since Sphinx 1.1.
Should we remove that or keep it maintained (everywhere)?

@StanFromIreland

StanFromIreland commented Nov 7, 2025

Copy link
Copy Markdown
MemberAuthor

Should we remove that or keep it maintained (everywhere)?

In my opinion, keeping the existing ones doesn’t have any significant impact, on the other hand, removing them is the same. I don't see any reason to add more. As such, I'm 0 on changing anything with them, although I don't mind removing them all (for consistency, it makes little sense to remove just the three) in this PR either, if you so wish.

@encukou

encukou commented Nov 10, 2025

Copy link
Copy Markdown
Member

I guess that if we do remove them, it should be its own PR.

@encukou
encukou merged commit 13fa313 into python:mainNov 10, 2025
33 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsNov 10, 2025
@encukouencukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@miss-islington-app

miss-islington-appBot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland@miss-islington
pythongh-139707: Specifywinreg,msvcrtandwinsoundmodule ava…
672471e
…ilability in docs (pythonGH-140429)
(cherry picked from commit 13fa313)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141350 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland@miss-islington
pythongh-139707: Specifywinreg,msvcrtandwinsoundmodule ava…
7cb6cf5
…ilability in docs (pythonGH-140429)
(cherry picked from commit 13fa313)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141351 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
encukou pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington@StanFromIreland
[3.14]gh-139707: Specifywinreg,msvcrtandwinsoundmodule av…
63a3737
…ailability in docs (GH-140429) (GH-141351)
(cherry picked from commit 13fa313)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington@StanFromIreland
[3.13]gh-139707: Specifywinreg,msvcrtandwinsoundmodule av…
1f9f8e5
…ailability in docs (GH-140429) (GH-141350)
(cherry picked from commit 13fa313)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@encukouencukou mentioned this pull request Nov 11, 2025
Closed
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-139707: Specifywinreg,msvcrtandwinsoundmodule ava…
5a5b0c6
…ilability in docs (pythonGH-140429)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiskaiskaisk approved these changes
@encukouencukouAwaiting requested review from encukou
@zoobazoobaAwaiting requested review from zooba

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@encukou@aisk