Skip to content

gh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined - #140446

Merged
encukou merged 3 commits into
python:mainfrom
encukou:guard-subvol
Oct 22, 2025
Merged

gh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined#140446
encukou merged 3 commits into
python:mainfrom
encukou:guard-subvol

Conversation

@encukou

@encukouencukou commented Oct 22, 2025

Copy link
Copy Markdown
Member

@encukou

Copy link
Copy Markdown
MemberAuthor

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit e879800 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

@encukou

Copy link
Copy Markdown
MemberAuthor

!buildbot AMD64.CentOS9.NoGIL$

@bedevere-bot

Copy link
Copy Markdown

The regex 'AMD64.CentOS9.NoGIL$' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@encukou

Copy link
Copy Markdown
MemberAuthor

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit f0d5edb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wrote a similar change before seeing yours :-)

@vstinner

Copy link
Copy Markdown
Member

Oh sorry, I created a conflict when I merged my other statx() change.

@encukou

Copy link
Copy Markdown
MemberAuthor

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0c95f7a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

@encukou

Copy link
Copy Markdown
MemberAuthor

Could you please run buildbots for any other statx changes?

@encukou
encukou merged commit e53e9eb into python:mainOct 22, 2025
45 checks passed
@encukou
encukou deleted the guard-subvol branch October 22, 2025 10:42
@vstinner

Copy link
Copy Markdown
Member

Could you please run buildbots for any other statx changes?

Ok, I will. We ran buildbots on the change causing the regression, but only some buildbots.

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@bedevere-bot@vstinner