Uh oh!
There was an error while loading. Please reload this page.
GH-140454: Remove pyconfig.h from Makefile JIT_DEPS - #140491
Closed
savannahostrowski wants to merge 1 commit into
Closed
GH-140454: Remove pyconfig.h from Makefile JIT_DEPS#140491savannahostrowski wants to merge 1 commit into
pyconfig.h from Makefile JIT_DEPS#140491savannahostrowski wants to merge 1 commit into
Conversation
savannahostrowski
requested review from
AA-Turner, emmatyping and erlend-aasland
as code ownersOctober 23, 2025 04:42
MemberAuthor
Would be good to get a Makefile expert's eyes on this 🙏 The results of my spelunking efforts: #140454 (comment) |
pyconfig.h from JIT_DEPSpyconfig.h from Makefile JIT_DEPShroncok
commented
Oct 23, 2025
Contributor
Thanks. I tested this, and it does not seem to solve the problem for me. Different shell: --- make._sysconfigdata__linux_x86_64-linux-gnu.py 2025-10-23 11:25:44.805777209 +0200+++ build/lib.linux-x86_64-3.15/_sysconfigdata__linux_x86_64-linux-gnu.py 2025-10-23 11:25:59.599337788 +0200@@ -19,7 +19,7 @@
'BINDIR': '/usr/local/bin',
'BINLIBDEST': '/usr/local/lib/python3.15',
'BLDLIBRARY': 'libpython3.15.a',
- 'BLDSHARED': 'gcc -shared',+ 'BLDSHARED': 'gcc -shared -Wl,--as-needed -g',
'BOOTSTRAP_HEADERS': '\\',
'BUILDEXE': '',
'BUILDPYTHON': 'python',
@@ -647,11 +647,12 @@
'IO_OBJS': '\\',
'IPHONEOS_DEPLOYMENT_TARGET': '',
'JIT_DEPS': '\\',
- 'LDCXXSHARED': 'g++ -shared',- 'LDFLAGS': '',+ 'LDCXXSHARED': 'g++ -shared -Wl,--as-needed -g',+ 'LDFLAGS': '-Wl,--as-needed -g',+ 'LDFLAGS_NODIST': '',
'LDLIBRARY': 'libpython3.15.a',
'LDLIBRARYDIR': '',
- 'LDSHARED': 'gcc -shared',+ 'LDSHARED': 'gcc -shared -Wl,--as-needed -g',
'LDVERSION': '3.15',
'LIBC': '',
'LIBDEST': '/usr/local/lib/python3.15',
@@ -987,8 +988,8 @@
'PY_CPPFLAGS': '-I. -I./Include',
'PY_ENABLE_SHARED': 0,
'PY_HAVE_PERF_TRAMPOLINE': 1,
- 'PY_LDFLAGS': '',- 'PY_LDFLAGS_NODIST': '-Wl,--as-needed -g -Wl,--as-needed -g',+ 'PY_LDFLAGS': '-Wl,--as-needed -g',+ 'PY_LDFLAGS_NODIST': '-Wl,--as-needed -g',
'PY_LDFLAGS_NOLTO': '-Wl,--as-needed -g',
'PY_SQLITE_ENABLE_LOAD_EXTENSION': 0,
'PY_SQLITE_HAVE_SERIALIZE': 0, |
savannahostrowski
commented
Oct 23, 2025
MemberAuthor
Wow, okay. I cannot reproduce this either locally or in a Fedora Devcontainer with the steps you've outlined above. I'll close this PR for now, and we can take the discussion back into the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make install#140454