gh-140544: store pointer to interpreter state as a thread local for fast access

[kumaraditya303]

• Issue: Store current interpreter as a thread local variable #140544

[ZeroIntensity]

The core change looks good. Mostly nitpicks from me.

[ZeroIntensity]

LGTM

[cdce8p]

Should this be

#if defined(HAVE_THREAD_LOCAL) && !defined(Py_BUILD_CORE_MODULE)

instead?

When testing the current main against mypyc, I'm seeing a new error message

In file included from /.../mypy/mypyc/lib-rt/misc_ops.c:1137:
In file included from /.../cpython/Include/internal/pycore_object.h:12:
In file included from /.../cpython/Include/internal/pycore_gc.h:12:
/.../cpython/Include/internal/pycore_pystate.h:213:12: error: use of undeclared identifier '_Py_tss_interp'
return _Py_tss_interp;
^
1 error generated.

Mypyc does use some of the internal headers. In particular

#definePy_BUILD_CORE
...
#include"internal/pycore_object.h"

[kumaraditya303]

I guess it is because mypyc doesn't define HAVE_THREAD_LOCAL which is defined when python is built, does #140623 fixes it for you?

[ZeroIntensity]

I think we should just remove the check for HAVE_THREAD_LOCAL on line 92.

[cdce8p]

I guess it is because mypyc doesn't define HAVE_THREAD_LOCAL which is defined when python is built, does #140623 fixes it for you?

Yes, that works.

I think we should just remove the check for HAVE_THREAD_LOCAL on line 92.

Guess, this would work too.