Skip to content

gh-139951: Tests on tuple tracking - #140575

Merged
vstinner merged 2 commits into
python:mainfrom
efimov-mikhail:issue-139951-tuple-track-tests
Oct 28, 2025
Merged

gh-139951: Tests on tuple tracking#140575
vstinner merged 2 commits into
python:mainfrom
efimov-mikhail:issue-139951-tuple-track-tests

Conversation

@efimov-mikhail

@efimov-mikhailefimov-mikhail commented Oct 25, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Since #140262 has been merged, there is no need in this PR #140204.

But I'd like to adapt some tests from that PR for the current implementation.

@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting review labels Oct 25, 2025
@bedevere-appbedevere-appBot mentioned this pull request Oct 25, 2025
Closed
@efimov-mikhailefimov-mikhail added skip news needs backport to 3.14 bugs and security fixes and removed tests Tests in the Lib/test dir awaiting review labels Oct 25, 2025
@efimov-mikhailefimov-mikhail mentioned this pull request Oct 25, 2025
Closed
sergey-miryanov
sergey-miryanov reviewed Oct 25, 2025
View reviewed changes
Comment threadLib/test/test_capi/test_tuple.py
sergey-miryanov
sergey-miryanov approved these changes Oct 27, 2025
View reviewed changes

@sergey-miryanovsergey-miryanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
vstinner merged commit 88ad41f into python:mainOct 28, 2025
45 checks passed
@miss-islington-app

miss-islington-appBot commented Oct 28, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Oct 28, 2025

Copy link
Copy Markdown

Sorry, @efimov-mikhail and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 88ad41fa3434444a8f316310bffde50e004156ce 3.14

@vstinner

vstinner commented Oct 28, 2025

Copy link
Copy Markdown
Member

Merged, thanks.

Can you please try to backport your change to 3.14? The automated backport failed.

@efimov-mikhail

efimov-mikhail commented Oct 28, 2025

Copy link
Copy Markdown
MemberAuthor

Thx for merge, Victor!
Of course, I'll try to make manual backport.

efimov-mikhail added a commit to efimov-mikhail/cpython that referenced this pull request Oct 28, 2025
@efimov-mikhail
pythongh-139951: Tests on tuple GC tracking (python#140575)
4583d27
@bedevere-app

bedevere-appBot commented Oct 28, 2025

Copy link
Copy Markdown

GH-140701 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Oct 28, 2025
vstinner pushed a commit that referenced this pull request Oct 29, 2025
@efimov-mikhail
[3.14]gh-139951: Tests on tuple GC tracking (GH-140575) (#140701)
8f322ad
@efimov-mikhail
efimov-mikhail deleted the issue-139951-tuple-track-tests branch October 29, 2025 14:39
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@efimov-mikhail@StanFromIreland
pythongh-139951: Tests on tuple GC tracking (python#140575)
241b9aa
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanovsergey-miryanovsergey-miryanov approved these changes
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

@vstinnervstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efimov-mikhail@vstinner@sergey-miryanov