gh-140715: provide support for %F token in strptime; add test for it and %T by jyalim · Pull Request #140647 · python/cpython

jyalim · 2025-10-27T00:07:35Z

Incrementally builds C99+ datetime support with addition of %F with single line of code. Also adds two tests: one for %F and another for previously supported %T.

Passed all tests (especially changes to new one).

Passed patchcheck.

Issue: strptime token support and documentation modernization #140644

Issue: Update str*time to C11 format codes #140715

bedevere-app · 2025-10-27T00:07:39Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

python-cla-bot · 2025-10-27T00:07:39Z

All commit authors signed the Contributor License Agreement.

StanFromIreland · 2025-10-28T18:34:06Z

I moved this under #140715, can you please update the blurb filename.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

…kozE0.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

jyalim · 2025-10-28T21:14:32Z

I moved this under #140715, can you please update the blurb filename.

I think this is done!

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

….py` instead)

StanFromIreland

Please add them to this tuple:

cpython/Lib/test/test_time.py

Lines 361 to 363 in a2495ff

fordirectivein ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I', 
'j', 'm', 'M', 'p', 'S', 
'U', 'w', 'W', 'x', 'X', 'y', 'Y', 'Z', '%'): 

Also, please update the docs removing the (0) note from its row.

The implementation looks good, just a few small things and this will be ready :-)

…kozE0.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Remove extra comments Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

shorten test name Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

shorten test function name Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

…tester request

jyalim · 2026-02-07T23:04:46Z

Thank you, @StanFromIreland, all changes have been made as requested!

jyalim · 2026-02-08T14:52:00Z

Thank you again, @StanFromIreland, changes have been made.

StanFromIreland

Last few things.

style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

…p.) and use `self.theclass.strptime`

jyalim · 2026-02-08T20:56:16Z

Thanks, @StanFromIreland, the requested changes were implemented!

StanFromIreland

LGTM

StanFromIreland · 2026-02-09T12:30:30Z

Thanks @jyalim, and congratulations for your first PR! Do you want to open a PR for one of the other format codes?

jyalim · 2026-02-14T04:12:36Z

It was a pleasure working with you, and it sounds fun! How would you prefer to organize the effort, just to link under issue: #140715?

StanFromIreland · 2026-02-14T08:27:12Z

Yes that sounds good!

…GH-140647) Also: add tests for the `%T` format code Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

provide support for %F token in strptime; add test for it and %T
92929d8

jyalim requested review from abalkin and pganssle as code owners October 27, 2025 00:07

bedevere-appBot added the awaiting review label Oct 27, 2025

bedevere-appBot mentioned this pull request Oct 27, 2025
strptime token support and documentation modernization #140644
Closed

📜🤖 Added by blurb_it.
b1bf9b4

StanFromIreland reviewed Oct 27, 2025
View reviewed changes

Comment threadLib/_strptime.py Outdated
Comment threadMisc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140644.WkozE0.rst Outdated
Comment threadLib/test/test_strptime.py Outdated

StanFromIreland changed the title ~~gh-140644: provide support for %F token in strptime; add test for it and %T~~gh-140715: provide support for %F token in strptime; add test for it and %TOct 28, 2025

bedevere-appBot mentioned this pull request Oct 28, 2025
Update str*time to C11 format codes #140715
Open
5 tasks

jyalimand others added 3 commits October 28, 2025 14:10

rm comment as recommended
d84fd54
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140644.W…
cb8d7d3
…kozE0.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Rename NEWS blurbit to match new github issue name
634ecea

Update test_strptime.py to use unittest methods, as requested
2e94037

StanFromIreland reviewed Oct 28, 2025
View reviewed changes

Comment threadLib/test/test_strptime.py Outdated
Comment threadLib/test/test_strptime.py Outdated
Comment threadMisc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.WkozE0.rst Outdated

jyalimand others added 4 commits October 28, 2025 14:36

simplify news per recommendation
c23b731
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Remove datetime tests from test_strptime.py (added to `datetimetester…
e77ff96
….py` instead)

Tests moved to datetimetester.py
ffbc215

Merge branch 'main' into fix-issue-140644
fb63ae7

StanFromIreland reviewed Feb 7, 2026
View reviewed changes

jyalimand others added 7 commits February 7, 2026 15:24

Update Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.W…
ff10b73
…kozE0.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/test_strptime.py
b4ec5f8
Remove extra comments Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/datetimetester.py
8513e1d
shorten test name Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/datetimetester.py
0a928e6
shorten test function name Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

refactor test for %F as requested
029ed4f

refactor test for %F and %T as requested
88c6f02

refactor test %T as requested; rename %F + %T tests to match datetime…
707ea08
…tester request

remove (0) note for %F in documentation, as requested
10ab774

StanFromIreland reviewed Feb 8, 2026
View reviewed changes

Comment threadDoc/library/datetime.rst Outdated
Comment threadDoc/library/datetime.rst Outdated

jyalim added 2 commits February 8, 2026 07:33

revert date change in
179afae

documenting %F addition to strptime
f56f54a

StanFromIreland reviewed Feb 8, 2026
View reviewed changes

jyalimand others added 7 commits February 8, 2026 13:30

Update Lib/test/test_strptime.py
29ba043
style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/datetimetester.py
7d4c618
style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Doc/library/datetime.rst
2cf4890
fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Doc/library/datetime.rst
c5593dd
fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/test_strptime.py
b0ca1d2
style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Update Lib/test/datetimetester.py
46981d1
style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

relocate test methods for %F and %T to TestDate and TestDateTime (res…
500552b
…p.) and use `self.theclass.strptime`

StanFromIreland reviewed Feb 8, 2026
View reviewed changes

Comment threadLib/test/datetimetester.py

Update Lib/test/datetimetester.py
18757eb

StanFromIreland approved these changes Feb 8, 2026
View reviewed changes

bedevere-appBot added awaiting core review and removed awaiting review labels Feb 8, 2026

encukou merged commit d99f3fc into python:mainFeb 9, 2026
51 checks passed

bedevere-appBot removed the awaiting core review label Feb 9, 2026

jyalim mentioned this pull request Feb 14, 2026
gh-140715: Add %D format code support to strptime()#144819
Merged

jyalim mentioned this pull request Feb 17, 2026
gh-140715: Add %t and %n format codes support to strptime() #144896
Merged

jyalim mentioned this pull request Mar 15, 2026
gh-140715: Add %C format code support to strptime() #145955
Open

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-140715: Add%Fformat code support tostrptime()(python…
a59a615
…GH-140647) Also: add tests for the `%T` format code Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

	fordirectivein ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I',
	'j', 'm', 'M', 'p', 'S',
	'U', 'w', 'W', 'x', 'X', 'y', 'Y', 'Z', '%'):

Uh oh!

Uh oh!

Conversation

jyalim commented Oct 27, 2025• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-appBot commented Oct 27, 2025

Uh oh!

python-cla-botBot commented Oct 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland commented Oct 28, 2025

Uh oh!

jyalim commented Oct 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 7, 2026

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 8, 2026

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 8, 2026

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanFromIreland commented Feb 9, 2026

Uh oh!

jyalim commented Feb 14, 2026

Uh oh!

StanFromIreland commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jyalim commented Oct 27, 2025•
edited by bedevere-app Bot
Loading

python-cla-botBot commented Oct 27, 2025•
edited
Loading