Skip to content

gh-116738: Use PyMutex for lzma module - #140711

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
yoney:ft_lzma
Nov 11, 2025
Merged

gh-116738: Use PyMutex for lzma module#140711
kumaraditya303 merged 3 commits into
python:mainfrom
yoney:ft_lzma

Conversation

@yoney

@yoneyyoney commented Oct 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Similar to #140555, the main goal was to review the lzma module for free-threading. The methods already use a lock, which makes them thread-safe in a free-threaded build. I replaced PyThread_acquire_lock with PyMutex. PyMutex releases the GIL when the thread is parked. This change removes some macros and allocation handling code.

cc: @mpage@colesbury@emmatyping

@bedevere-appbedevere-appBot mentioned this pull request Oct 28, 2025
Open
@yoney
yoney marked this pull request as ready for review October 28, 2025 16:39
ashm-dev
ashm-dev reviewed Oct 28, 2025
View reviewed changes
Comment threadLib/test/test_free_threading/test_lzma.py
ashm-dev
ashm-dev reviewed Oct 28, 2025
View reviewed changes
Comment threadLib/test/test_free_threading/test_lzma.py
ashm-dev
ashm-dev reviewed Oct 28, 2025
View reviewed changes
Comment threadLib/test/test_free_threading/test_lzma.py
kumaraditya303
kumaraditya303 reviewed Nov 6, 2025
View reviewed changes
Comment threadLib/test/test_free_threading/test_lzma.py Outdated
@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2025
@bedevere-bot

bedevere-bot commented Nov 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 92a8faa 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140711%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2025
@kumaraditya303
kumaraditya303 merged commit c13b592 into python:mainNov 11, 2025
123 of 124 checks passed
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@yoney@kumaraditya303@StanFromIreland
pythongh-116738: usePyMutexinlzmamodule (python#140711)
472ccf4
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@yoneyyoney mentioned this pull request Dec 8, 2025
Merged
@yoneyyoney mentioned this pull request Dec 18, 2025
Merged
@yoney
yoney deleted the ft_lzma branch January 27, 2026 17:07
@ByteFlowing1337ByteFlowing1337 mentioned this pull request Jul 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@colesburycolesburyAwaiting requested review from colesbury
@emmatypingemmatypingAwaiting requested review from emmatyping
@mpagempageAwaiting requested review from mpage
+1 more reviewer
@ashm-devashm-devashm-dev left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yoney@bedevere-bot@ZeroIntensity@kumaraditya303@ashm-dev@mpage