Skip to content

gh-140373: Correctly emit PY_UNWIND event when generator is closed - #140767

Merged
markshannon merged 4 commits into
python:mainfrom
efimov-mikhail:issue-140373-gen-unwind
Oct 31, 2025
Merged

gh-140373: Correctly emit PY_UNWIND event when generator is closed#140767
markshannon merged 4 commits into
python:mainfrom
efimov-mikhail:issue-140373-gen-unwind

Conversation

@efimov-mikhail

@efimov-mikhailefimov-mikhail commented Oct 29, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Oct 29, 2025
Closed
@efimov-mikhailefimov-mikhail added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 29, 2025
markshannon
markshannon approved these changes Oct 30, 2025
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for fixing this.

@efimov-mikhail

efimov-mikhail commented Oct 30, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks for the review, @markshannon!

Could you please merge this? Unfortunately, I don't have access to this "magic" button. Sorry, if this is not appropriate.

@markshannon
markshannon merged commit d17f28f into python:mainOct 31, 2025
56 checks passed
@miss-islington-app

miss-islington-appBot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
@efimov-mikhail@miss-islington
pythongh-140373: Correctly emitPY_UNWINDevent when generator is c…
615943f
…losed (pythonGH-140767)
(cherry picked from commit d17f28f)
Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
@miss-islington-app

miss-islington-appBot commented Oct 31, 2025

Copy link
Copy Markdown

Sorry, @efimov-mikhail and @markshannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d17f28fed5cfbb400f8dd9826c67d87c65f261a0 3.13

@bedevere-app

bedevere-appBot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140816 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Oct 31, 2025
efimov-mikhail added a commit to efimov-mikhail/cpython that referenced this pull request Oct 31, 2025
@efimov-mikhail
pythongh-140373: Correctly emitPY_UNWINDevent when generator is c…
1d92049
…losed (pythonGH-140767)
@bedevere-app

bedevere-appBot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140821 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Oct 31, 2025
hugovk pushed a commit that referenced this pull request Nov 30, 2025
@miss-islington@efimov-mikhail
[3.14]gh-140373: Correctly emitPY_UNWINDevent when generator is …
52731c4
…closed (GH-140767) (#140816)
Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@efimov-mikhail@StanFromIreland
pythongh-140373: Correctly emitPY_UNWINDevent when generator is c…
cd956f5
…losed (pythonGH-140767)
hugovk pushed a commit that referenced this pull request Dec 20, 2025
@efimov-mikhail
[3.13]gh-140373: Correctly emit PY_UNWIND event when generator is cl…
4504ff8
…osed (GH-140767) (#140821)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees

@markshannonmarkshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@efimov-mikhail@markshannon