Skip to content

gh-140939: Fix memory leak in _PyBytes_FormatEx error path - #140957

Merged
kumaraditya303 merged 5 commits into
python:mainfrom
StanFromIreland:bytes-leak
Nov 6, 2025
Merged

gh-140939: Fix memory leak in _PyBytes_FormatEx error path#140957
kumaraditya303 merged 5 commits into
python:mainfrom
StanFromIreland:bytes-leak

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Nov 3, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

It is already accounted for in the other path:

cpython/Objects/bytesobject.c

Lines 1049 to 1054 in b373d34

if (dict&& (argidx<arglen)) {
PyErr_SetString(PyExc_TypeError,
"not all arguments converted during bytes formatting");
Py_XDECREF(temp);
goto error;
}

@bedevere-appbedevere-appBot mentioned this pull request Nov 3, 2025
Closed
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
Comment threadLib/test/test_bytes.py Outdated
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
Comment threadLib/test/test_bytes.py Outdated
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
Comment threadLib/test/test_bytes.py
vstinner
vstinner approved these changes Nov 5, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@kumaraditya303
kumaraditya303 merged commit d6c89a2 into python:mainNov 6, 2025
56 checks passed
@miss-islington-app

miss-islington-appBot commented Nov 6, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 6, 2025

Copy link
Copy Markdown

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.14

@miss-islington-app

miss-islington-appBot commented Nov 6, 2025

Copy link
Copy Markdown

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.13

@StanFromIreland
StanFromIreland deleted the bytes-leak branch November 6, 2025 07:22
@StanFromIreland

StanFromIreland commented Nov 6, 2025

Copy link
Copy Markdown
MemberAuthor

I can backport.

@StanFromIrelandStanFromIreland self-assigned this Nov 6, 2025
@bedevere-app

bedevere-appBot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141154 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.14]pythongh-140939: Fix memory leak in_PyBytes_FormatExerror …
72c7e46
…path (pythonGH-140957)
(cherry picked from commit d6c89a2)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.13]pythongh-140939: Fix memory leak in_PyBytes_FormatExerror …
ca6837d
…path (pythonGH-140957)
(cherry picked from commit d6c89a2)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141155 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
vstinner pushed a commit that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.13]gh-140939: Fix memory leak in_PyBytes_FormatExerror path (G…
f1a9372
…H-140957) (#141155)
(cherry picked from commit d6c89a2)
vstinner pushed a commit that referenced this pull request Nov 6, 2025
@StanFromIreland
[3.14]gh-140939: Fix memory leak in_PyBytes_FormatExerror path (G…
ebf5459
…H-140957) (#141154)
(cherry picked from commit d6c89a2)
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-140939: Fix memory leak in_PyBytes_FormatExerror path (p…
1fefb4f
…ython#140957)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@kumaraditya303kumaraditya303kumaraditya303 approved these changes
+1 more reviewer
@RenaudBernierRenaudBernierRenaudBernier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StanFromIrelandStanFromIreland

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@vstinner@kumaraditya303@RenaudBernier