Docs: fix a form error and a grammatical error in float.rst by F18-Maverick · Pull Request #140989 · python/cpython

F18-Maverick · 2025-11-04T12:03:36Z

📚 Documentation preview 📚: https://cpython-previews--140989.org.readthedocs.build/

skirpichev

And there is a merge conflict.

skirpichev · 2025-11-10T01:03:48Z

 exception.

-Note that NaNs type may not be preserved on IEEE platforms (silent NaN become
+Note that NaN types may not be preserved on IEEE platforms (silent NaN become


Suggested change
Note that NaN types may not be preserved on IEEE platforms (silent NaN become
Note that NaN type may not be preserved on IEEE platforms (silent NaN become
?

Okay, I think NaN type is better.

F18-Maverick · 2025-11-10T03:20:22Z

And you said that there is a merge conflict. So is there anything I can do?

skirpichev · 2025-11-10T03:43:32Z

You can resolve merge conflict.

F18-Maverick · 2025-11-10T03:56:24Z

Sorry, but how can I resolve it? I mean this is the first time I meet the merge conflict problem, and I just checked my python repo branches list, there is no problem. So do you mean I can't fix two issues in one PR?

skirpichev · 2025-11-10T04:29:46Z

You can just push "Resolve conflict" button in your pr:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts

Or do it from the command-line:
https://devguide.python.org/getting-started/git-boot-camp/#git-boot-camp
https://devguide.python.org/getting-started/pull-request-lifecycle/#resolving-merge-conflicts

F18-Maverick · 2025-11-10T05:05:50Z

Okay, so what about now?

skirpichev · 2025-11-10T05:14:56Z


-Note that NaNs type may not be preserved on IEEE platforms (signaling NaN become
-quiet NaN), for example on x86 systems in 32-bit mode.
+Note that NaN types may not be preserved on IEEE platforms (silent NaN become


Sorry, no. Now you reverted back change from #141179. Plese undo this.

Corrected the description of NaN type preservation on IEEE platforms.

F18-Maverick · 2025-11-10T05:22:55Z

Okay, I just reverted back the change and change NaNs type to NaN type.

F18-Maverick · 2025-11-12T12:26:45Z

Emm.. So is it the time to merge my PR? I think there is no problem right?

skirpichev · 2025-11-12T12:41:29Z

PR must be approved and merged by core developer.

F18-Maverick · 2025-11-12T12:48:53Z

Yes, I know that.

F18-Maverick · 2025-11-28T16:26:30Z

I'm sorry, but it's been quite a while since I submitted it, and I believe it's ready to be merged. I would greatly appreciate it if you could remind a core developer to take a look and merge the PR. Thank you!

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

StanFromIreland · 2026-02-10T14:22:25Z

 The pack routines write 2, 4 or 8 bytes, starting at *p*. *le* is an
 :c:expr:`int` argument, non-zero if you want the bytes string in little-endian
-format (exponent last, at ``p+1``, ``p+3``, or ``p+6`` and ``p+7``), zero if you
+format (exponent last, at ``p+1``, ``p+3``, or ``p+6``, ``p+7``), zero if you


IMO "and" was better.

miss-islington-app · 2026-03-16T08:21:53Z

Thanks @F18-Maverick for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…-140989) (cherry picked from commit 70397fd) Co-authored-by: RayXu <xu_ruihong2009@163.com>

miss-islington-app · 2026-03-16T08:22:01Z

Sorry, @F18-Maverick and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 70397fd1030c310d4d80beeb9c0d88f40c9abed8 3.13

bedevere-app · 2026-03-16T08:22:04Z

GH-146012 is a backport of this pull request to the 3.14 branch.

…H-140989) (#146012) Docs: fix a form error and a grammatical error in float.rst (GH-140989) (cherry picked from commit 70397fd) Co-authored-by: RayXu <xu_ruihong2009@163.com>

…40989)

serhiy-storchaka · 2026-07-15T10:59:50Z

Please don't forget about backports.

AjobK · 2026-07-19T08:15:37Z

As this documentation did not exist yet in version 3.13, it makes no sense to backport just this typo. Instead, if we would like to do this we should apply the entire section of documentation, which I believe falls out of scope.

StanFromIreland · 2026-07-19T08:24:15Z

Thanks for investigating!

Docs: fix a form error and a grammatical error in float.rst
891f667

bedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Nov 4, 2025

github-project-automationBot added this to Docs PRs Nov 4, 2025

github-project-automationBot moved this to Todo in Docs PRs Nov 4, 2025

skirpichev added the skip issue label Nov 4, 2025

This comment was marked as outdated.
Sign in to view

skirpichev reviewed Nov 10, 2025
View reviewed changes

skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025

Merge branch 'main' into fix-doc-issue-float.rst
e159f96

skirpichev reviewed Nov 10, 2025
View reviewed changes

Fix NaN type preservation wording in float.rst
c1cd87a
Corrected the description of NaN type preservation on IEEE platforms.

skirpichev approved these changes Nov 10, 2025
View reviewed changes

bedevere-appBot added awaiting core review and removed awaiting review labels Nov 10, 2025

Merge branch 'main' into fix-doc-issue-float.rst
b427f31

kumaraditya303 requested a review from StanFromIreland February 9, 2026 13:51

StanFromIreland reviewed Feb 9, 2026
View reviewed changes

Comment threadDoc/c-api/float.rst Outdated
Comment threadDoc/c-api/float.rst

F18-Maverickand others added 3 commits February 10, 2026 10:10

Update Doc/c-api/float.rst
bf04e14
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Apply suggestion from@skirpichev
1561fc1
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

Merge branch 'main' into fix-doc-issue-float.rst
fba1d4d

StanFromIreland reviewed Feb 10, 2026
View reviewed changes

Fix formatting in float.rst documentation
babb1e3

skirpichev added a commit to skirpichev/cpython that referenced this pull request Mar 13, 2026
+ changes frompython#140989
9124afb

kumaraditya303 approved these changes Mar 16, 2026
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels Mar 16, 2026

kumaraditya303 merged commit 70397fd into python:mainMar 16, 2026
33 checks passed

github-project-automationBot moved this from Todo to Done in Docs PRs Mar 16, 2026

bedevere-appBot removed the awaiting merge label Mar 16, 2026

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2026
Docs: fix a form error and a grammatical error in float.rst (pythonGH…
80763d2
…-140989) (cherry picked from commit 70397fd) Co-authored-by: RayXu <xu_ruihong2009@163.com>

miss-islington-appBot assigned kumaraditya303 Mar 16, 2026

bedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Mar 16, 2026

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Docs: fix a form error and a grammatical error in float.rst (python#1…
5438809
…40989)

StanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2026

	Note that NaN types may not be preserved on IEEE platforms (silent NaN become
	Note that NaN type may not be preserved on IEEE platforms (silent NaN become

Uh oh!

Uh oh!

Conversation

F18-Maverick commented Nov 4, 2025• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

skirpichev left a comment

Choose a reason for hiding this comment

Uh oh!

skirpichevNov 10, 2025

Choose a reason for hiding this comment

Uh oh!

F18-MaverickNov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

F18-Maverick commented Nov 10, 2025

Uh oh!

skirpichev commented Nov 10, 2025

Uh oh!

F18-Maverick commented Nov 10, 2025

Uh oh!

skirpichev commented Nov 10, 2025

Uh oh!

F18-Maverick commented Nov 10, 2025

Uh oh!

skirpichevNov 10, 2025

Choose a reason for hiding this comment

Uh oh!

F18-Maverick commented Nov 10, 2025

Uh oh!

F18-Maverick commented Nov 12, 2025

Uh oh!

skirpichev commented Nov 12, 2025

Uh oh!

F18-Maverick commented Nov 12, 2025

Uh oh!

F18-Maverick commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

StanFromIrelandFeb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-appBot commented Mar 16, 2026

Uh oh!

miss-islington-appBot commented Mar 16, 2026

Uh oh!

bedevere-appBot commented Mar 16, 2026

Uh oh!

serhiy-storchaka commented Jul 15, 2026

Uh oh!

AjobK commented Jul 19, 2026

Uh oh!

StanFromIreland commented Jul 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

F18-Maverick commented Nov 4, 2025•
edited by github-actions Bot
Loading