Uh oh!
There was an error while loading. Please reload this page.
gh-141174: Improve annotationlib.call_annotate_function() test coverage - #141176
Merged
Conversation
JelleZijlstra
commented
Nov 7, 2025
Member
One test is failing, could you take a look? |
dr-carlos
commented
Nov 7, 2025
ContributorAuthor
Fixed. |
Uh oh!
There was an error while loading. Please reload this page.
Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 10, 2025
…t coverage (pythonGH-141176) * Test passing unsupported Format values to call_annotate_function() * Test call_evaluate_function with fake globals that raise errors * Fix typo and comparison in test_fake_global_evaluation (cherry picked from commit 1110e8f) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
GH-141355 is a backport of this pull request to the 3.14 branch. |
JelleZijlstra pushed a commit
that referenced
this pull request
Nov 10, 2025
…st coverage (GH-141176) (#141355) gh-141174: Improve `annotationlib.call_annotate_function()` test coverage (GH-141176) * Test passing unsupported Format values to call_annotate_function() * Test call_evaluate_function with fake globals that raise errors * Fix typo and comparison in test_fake_global_evaluation (cherry picked from commit 1110e8f) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
StanFromIreland pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…t coverage (python#141176) * Test passing unsupported Format values to call_annotate_function() * Test call_evaluate_function with fake globals that raise errors * Fix typo and comparison in test_fake_global_evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All lines in
call_annotate_function()should now be covered.This PR includes an added test for
call_evaluate_function()as this just callscall_annotate_function()under the hood and some of its code paths weren't being tested.