Skip to content

gh-140980: document SET_FUNCTION_ATTRIBUTE flag for annotate function - #141306

Merged
picnixz merged 3 commits into
python:mainfrom
Lakshya-Upadhyaya:document-set-function-attribute-16
Nov 9, 2025
Merged

gh-140980: document SET_FUNCTION_ATTRIBUTE flag for annotate function #141306
picnixz merged 3 commits into
python:mainfrom
Lakshya-Upadhyaya:document-set-function-attribute-16

Conversation

@Lakshya-Upadhyaya

@Lakshya-UpadhyayaLakshya-Upadhyaya commented Nov 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixesgh-140980

This adds documentation for the 0x10 bit flag (annotate) that was added to
SET_FUNCTION_ATTRIBUTE in #124566. The bit sets the annotate function for
the function object.

📚 Documentation preview 📚: https://cpython-previews--141306.org.readthedocs.build/

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Nov 9, 2025
@picnixzpicnixz changed the title Doc: Add SET_FUNCTION_ATTRIBUTE 0x10 (annotate) to dis documentationgh-141155: document SET_FUNCTION_ATTRIBUTE in disNov 9, 2025
@StanFromIrelandStanFromIreland changed the title gh-141155: document SET_FUNCTION_ATTRIBUTE in disgh-140980: document SET_FUNCTION_ATTRIBUTE in disNov 9, 2025
@bedevere-appbedevere-appBot mentioned this pull request Nov 9, 2025
Closed
picnixz
picnixz reviewed Nov 9, 2025
View reviewed changes
Comment threadDoc/library/dis.rst Outdated
picnixz
picnixz reviewed Nov 9, 2025
View reviewed changes
Comment threadDoc/library/dis.rst
Comment on lines +1681 to 1682
Added ``0x10`` to indicate the annotate function for the function object.

@picnixzpicnixzNov 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put two blank lines between the end the sentence and the next .. opcode::? (see other paragraphs to check how they are separated)

picnixz
picnixz reviewed Nov 9, 2025
View reviewed changes
Comment threadDoc/library/dis.rst Outdated
@Lakshya-Upadhyaya
Lakshya-Upadhyayaforce-pushed the document-set-function-attribute-16 branch from ae00464 to 38151bfCompareNovember 9, 2025 18:19
@picnixzpicnixz added the needs backport to 3.14 bugs and security fixes label Nov 9, 2025
@picnixzpicnixz changed the title gh-140980: document SET_FUNCTION_ATTRIBUTE in disgh-140980: document SET_FUNCTION_ATTRIBUTE flag for annotate function Nov 9, 2025
@picnixz
picnixz merged commit 6f20ea1 into python:mainNov 9, 2025
34 checks passed
@miss-islington-app

miss-islington-appBot commented Nov 9, 2025

Copy link
Copy Markdown

Thanks @Lakshya-Upadhyaya for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsNov 9, 2025
@picnixz

picnixz commented Nov 9, 2025

Copy link
Copy Markdown
Member

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
@Lakshya-Upadhyaya@miss-islington
pythongh-140980: documentSET_FUNCTION_ATTRIBUTEflag for `annotate…
91eae22
…` function (pythonGH-141306)
(cherry picked from commit 6f20ea1)
Co-authored-by: Lakshya Upadhyaya <lakshya.upadhyaya05@gmail.com>
@bedevere-app

bedevere-appBot commented Nov 9, 2025

Copy link
Copy Markdown

GH-141316 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2025
picnixz pushed a commit that referenced this pull request Nov 9, 2025
@miss-islington@Lakshya-Upadhyaya
[3.14]gh-140980: documentSET_FUNCTION_ATTRIBUTEflag for `annotat…
86c6309
…e` function (GH-141306) (#141316)
gh-140980: document `SET_FUNCTION_ATTRIBUTE` flag for `annotate` function (GH-141306)
(cherry picked from commit 6f20ea1)
Co-authored-by: Lakshya Upadhyaya <lakshya.upadhyaya05@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@Lakshya-Upadhyaya@StanFromIreland
pythongh-140980: documentSET_FUNCTION_ATTRIBUTEflag for `annotate…
fe802d6
…` function (python#141306)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing documentation for SET_FUNCTION_ATTRIBUTE 16/0x10 (“annotate“)

2 participants

@Lakshya-Upadhyaya@picnixz