Skip to content

gh-62480: De-personalize "Partial mocking" section in unittest.mock examples - #141321

Merged
CAM-Gerlach merged 6 commits into
python:mainfrom
KarnbirKhera:patch-1
Nov 9, 2025
Merged

gh-62480: De-personalize "Partial mocking" section in unittest.mock examples#141321
CAM-Gerlach merged 6 commits into
python:mainfrom
KarnbirKhera:patch-1

Conversation

@KarnbirKhera

@KarnbirKheraKarnbirKhera commented Nov 9, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.

📚 Documentation preview 📚: https://cpython-previews--141321.org.readthedocs.build/

@KarnbirKhera
Refining some wording in unittest partial mock doc
aa61223
Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.
@python-cla-bot

python-cla-botBot commented Nov 9, 2025•
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Nov 9, 2025
@bedevere-appbedevere-appBot mentioned this pull request Nov 9, 2025
Open
@CAM-Gerlach
CAM-Gerlach self-requested a review November 9, 2025 23:01
@CAM-GerlachCAM-Gerlach self-assigned this Nov 9, 2025
@CAM-GerlachCAM-Gerlach changed the title GH-62480: Refining some wording in unittest partial mock docGH-62480: Refine some wording in unittest partial mock docNov 9, 2025
@CAM-GerlachCAM-Gerlach changed the title GH-62480: Refine some wording in unittest partial mock docGH-62480: Avoid first person in unittest partial mock docNov 9, 2025
CAM-Gerlach
CAM-Gerlach requested changes Nov 9, 2025
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some further textual refinements, otherwise LGTM

Comment threadDoc/library/unittest.mock-examples.rst Outdated
Comment threadDoc/library/unittest.mock-examples.rst Outdated
Comment threadDoc/library/unittest.mock-examples.rst Outdated
Comment threadDoc/library/unittest.mock-examples.rst Outdated
Comment threadDoc/library/unittest.mock-examples.rst Outdated
@bedevere-app

bedevere-appBot commented Nov 9, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@CAM-GerlachCAM-Gerlach added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 9, 2025
KarnbirKheraand others added 5 commits November 9, 2025 15:09
@KarnbirKhera@CAM-Gerlach
Update Doc/library/unittest.mock-examples.rst
97cc04a
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@KarnbirKhera@CAM-Gerlach
Update Doc/library/unittest.mock-examples.rst
5c4f4c5
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@KarnbirKhera@CAM-Gerlach
Update Doc/library/unittest.mock-examples.rst
602858c
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@KarnbirKhera@CAM-Gerlach
Update Doc/library/unittest.mock-examples.rst
8eb1a2b
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@KarnbirKhera@CAM-Gerlach
Update Doc/library/unittest.mock-examples.rst
41be688
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
KarnbirKhera
KarnbirKhera commented Nov 9, 2025
View reviewed changes

@KarnbirKheraKarnbirKhera left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make the document more accurate. Added to original request.

@picnixzpicnixz changed the title GH-62480: Avoid first person in unittest partial mock docgh-62480: De-personalize "Partial mocking" section in unittest.mock examplesNov 9, 2025
CAM-Gerlach
CAM-Gerlach approved these changes Nov 9, 2025
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @KarnbirKhera !

@CAM-Gerlach
CAM-Gerlach merged commit b618731 into python:mainNov 9, 2025
31 of 32 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsNov 9, 2025
@miss-islington-app

miss-islington-appBot commented Nov 9, 2025

Copy link
Copy Markdown

Thanks @KarnbirKhera for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
@KarnbirKhera@CAM-Gerlach@miss-islington
pythongh-62480: De-personalize "Partial mocking" section in `unittest…
6ae42f8
….mock` examples (pythonGH-141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
(cherry picked from commit b618731)
Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-app

bedevere-appBot commented Nov 9, 2025

Copy link
Copy Markdown

GH-141326 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
@KarnbirKhera@CAM-Gerlach@miss-islington
pythongh-62480: De-personalize "Partial mocking" section in `unittest…
61346a5
….mock` examples (pythonGH-141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
(cherry picked from commit b618731)
Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-app

bedevere-appBot commented Nov 9, 2025

Copy link
Copy Markdown

GH-141327 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 9, 2025
CAM-Gerlach added a commit that referenced this pull request Nov 10, 2025
@miss-islington@KarnbirKhera@CAM-Gerlach
[3.13]gh-62480: De-personalize "Partial mocking" section in `unittes…
379d814
…t.mock` examples (GH-141321) (#141327)
gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
(cherry picked from commit b618731)
Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach added a commit that referenced this pull request Nov 10, 2025
@miss-islington@KarnbirKhera@CAM-Gerlach
[3.14]gh-62480: De-personalize "Partial mocking" section in `unittes…
6cbb8cb
…t.mock` examples (GH-141321) (#141326)
gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
(cherry picked from commit b618731)
Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@KarnbirKhera@CAM-Gerlach@StanFromIreland
pythongh-62480: De-personalize "Partial mocking" section in `unittest…
805543e
….mock` examples (python#141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

Assignees

@CAM-GerlachCAM-Gerlach

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KarnbirKhera@CAM-Gerlach