Uh oh!
There was an error while loading. Please reload this page.
gh-116738: Make csv module thread-safe - #141365
Merged
Merged
Conversation
yoney
marked this pull request as ready for review
November 10, 2025 17:04
Thanks @yoney for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2025
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing. (cherry picked from commit fb26d9c) Co-authored-by: Alper <alperyoney@fb.com>
GH-141825 is a backport of this pull request to the 3.14 branch. |
colesbury pushed a commit
that referenced
this pull request
Nov 21, 2025
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing. (cherry picked from commit fb26d9c) Co-authored-by: Alper <alperyoney@fb.com>
StanFromIreland pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
ashm-dev pushed a commit
to ashm-dev/cpython
that referenced
this pull request
Dec 8, 2025
Added a critical section to protect the states of `ReaderObj` and `WriterObj` in the free-threading build. Without the critical sections, both new free-threading tests were crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a critical section to protect the states of
ReaderObjandWriterObjin the free-threading build. Without the critical sections, both new free-threading tests were crashing. Also ran the tests with tsan.cc: @mpage@colesbury