Uh oh!
There was an error while loading. Please reload this page.
[3.14] gh-140104: Set next_instr properly in the JIT during exceptions (GH-140233) - #141495
Merged
Fidget-Spinner merged 6 commits intoNov 13, 2025
Conversation
efimov-mikhail
requested review from
Fidget-Spinner
and removed request for
markshannonNovember 13, 2025 09:54
This was referenced Nov 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner
commented
Nov 13, 2025
Member
Could you pleas trigger the JIT CI by pushing whitespace to a jit file? We can revert that after I see it's green. |
efimov-mikhail
requested review from
brandtbucher and savannahostrowski
as code ownersNovember 13, 2025 15:31
efimov-mikhail
commented
Nov 13, 2025
MemberAuthor
Sure! I hope that I understand correctly what file do you mean ( |
Fidget-Spinner
commented
Nov 13, 2025
Member
Very cool. It's green! Ok, please revert the jit file change and I'll merge it. |
Fidget-Spinner
approved these changes
Nov 13, 2025
Fidget-Spinner
commented
Nov 13, 2025
Member
Thanks again. |
Uh oh!
There was an error while loading. Please reload this page.
efimov-mikhail
commented
Nov 13, 2025
MemberAuthor
Thank you for review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an another attempt to backport GH-140233.
The first one was buggy and we reverted it.
CC @Fidget-Spinner.
I'm not sure that this fix is fully correct.
But it passes all the tests on my machine (Debian 12, x86_64) in both build configurations:
UnboundLocalErrorfor same code with JIT on or off #140104