Skip to content

gh-141627: Fix BufferedRandom inheritance documentation - #141629

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
mohsinm-dev:fix-bufferedrandom-docs-gh-141627
Jun 2, 2026
Merged

gh-141627: Fix BufferedRandom inheritance documentation#141629
serhiy-storchaka merged 4 commits into
python:mainfrom
mohsinm-dev:fix-bufferedrandom-docs-gh-141627

Conversation

@mohsinm-dev

@mohsinm-devmohsinm-dev commented Nov 16, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Fix incorrect documentation stating BufferedRandom inherits from BufferedReader and BufferedWriter. It actually inherits from BufferedIOBase in the C implementation.

📚 Documentation preview 📚: https://cpython-previews--141629.org.readthedocs.build/

@mohsinm-dev
pythongh-141627: Fix BufferedRandom inheritance documentation
42d8384
BufferedRandom does not inherit from BufferedReader and BufferedWriter
in the C implementation. Update documentation to accurately state that
it inherits from BufferedIOBase and provides combined functionality.
@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Nov 16, 2025
@bedevere-appbedevere-appBot mentioned this pull request Nov 16, 2025
Closed
cmaloney
cmaloney reviewed Nov 18, 2025
View reviewed changes
Comment threadDoc/library/io.rst Outdated
@github-actions

github-actionsBot commented May 2, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label May 2, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jun 2, 2026
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 2, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) June 2, 2026 18:00
@serhiy-storchaka
serhiy-storchaka merged commit 551bc2c into python:mainJun 2, 2026
36 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in Docs PRsJun 2, 2026
@miss-islington-app

miss-islington-appBot commented Jun 2, 2026

Copy link
Copy Markdown

Thanks @mohsinm-dev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jun 2, 2026

Copy link
Copy Markdown

GH-150801 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 2, 2026
@bedevere-app

bedevere-appBot commented Jun 2, 2026

Copy link
Copy Markdown

GH-150802 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jun 2, 2026
@bedevere-app

bedevere-appBot commented Jun 2, 2026

Copy link
Copy Markdown

GH-150803 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 2, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jun 2, 2026
@miss-islington@mohsinm-dev
[3.13]gh-141627: Fix BufferedRandom inheritance documentation (GH-14…
d3bfccd
…1629) (GH-150803)
BufferedRandom does not inherit from BufferedReader and BufferedWriter
in the C implementation.
(cherry picked from commit 551bc2c)
Co-authored-by: Mohsin Mehmood <55545648+mohsinm-dev@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 2, 2026
@miss-islington@mohsinm-dev
[3.14]gh-141627: Fix BufferedRandom inheritance documentation (GH-14…
a7ce8ac
…1629) (GH-150802)
BufferedRandom does not inherit from BufferedReader and BufferedWriter
in the C implementation.
(cherry picked from commit 551bc2c)
Co-authored-by: Mohsin Mehmood <55545648+mohsinm-dev@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 2, 2026
@miss-islington@mohsinm-dev
[3.15]gh-141627: Fix BufferedRandom inheritance documentation (GH-14…
d5f93ce
…1629) (GH-150801)
BufferedRandom does not inherit from BufferedReader and BufferedWriter
in the C implementation.
(cherry picked from commit 551bc2c)
Co-authored-by: Mohsin Mehmood <55545648+mohsinm-dev@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloneycmaloneycmaloney approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip newsstaleStale PR or inactive for long period of time.

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohsinm-dev@cmaloney@serhiy-storchaka@nazeerali4325-commits