Skip to content

gh-141909: Add PyModuleDef_Slot and earlier Py_mod_* constants to stable ABI manifest - #141910

Merged
encukou merged 4 commits into
python:mainfrom
encukou:py-mod-stable-abi
Nov 25, 2025
Merged

gh-141909: Add PyModuleDef_Slot and earlier Py_mod_* constants to stable ABI manifest#141910
encukou merged 4 commits into
python:mainfrom
encukou:py-mod-stable-abi

Conversation

@encukou

@encukouencukou commented Nov 24, 2025•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Nov 24, 2025
Closed
vstinner
vstinner approved these changes Nov 24, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serhiy-storchaka
serhiy-storchaka reviewed Nov 24, 2025
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we add also .. versionadded:: 3.5 in the documentation for Py_mod_create and Py_mod_exec?

Is the PyModuleDef_Slot structure type in the stable ABI or only in the limited API?

@encukouencukou changed the title gh-141909: Add earlier Py_mod_* constants to stable ABI manifestgh-141909: Add PyModuleDef_Slot and earlier Py_mod_* constants to stable ABI manifestNov 25, 2025
@encukou

encukou commented Nov 25, 2025

Copy link
Copy Markdown
MemberAuthor

Good points, thank you!

serhiy-storchaka
serhiy-storchaka approved these changes Nov 25, 2025
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@encukou
encukou merged commit 202fce0 into python:mainNov 25, 2025
28 checks passed
@encukou
encukou deleted the py-mod-stable-abi branch November 25, 2025 14:16
@encukouencukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 25, 2025
@miss-islington-app

miss-islington-appBot commented Nov 25, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 25, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Nov 25, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 202fce0dbde1da32d8abc2eb59ddfce6f6a3c9fa 3.13

@miss-islington-app

miss-islington-appBot commented Nov 25, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 202fce0dbde1da32d8abc2eb59ddfce6f6a3c9fa 3.14

encukou added a commit to encukou/cpython that referenced this pull request Nov 26, 2025
@encukou
pythongh-141909: AddPyModuleDef_Slotand earlier Py_mod_* constant…
6b9a3f1
…s to stable ABI manifest (python#141910)
These were added to the limited API in 3.5.
Not including them in `Misc/stable_abi.toml` was a bug.
(cherry picked from commit 202fce0)
@bedevere-app

bedevere-appBot commented Nov 26, 2025

Copy link
Copy Markdown

GH-141977 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Nov 26, 2025
@bedevere-app

bedevere-appBot commented Nov 26, 2025

Copy link
Copy Markdown

GH-141978 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Nov 26, 2025
encukou added a commit to encukou/cpython that referenced this pull request Nov 26, 2025
@encukou
[3.14]pythongh-141909: AddPyModuleDef_Slotand earlier Py_mod_* c…
587bfda
…onstants to stable ABI manifest (python#141910)
These were added to the limited API in 3.5-3.13.
Not including them in `Misc/stable_abi.toml` was a bug.
(cherry picked from commit 202fce0)
encukou added a commit that referenced this pull request Nov 26, 2025
@encukou
[3.13]gh-141909: AddPyModuleDef_Slotand earlier Py_mod_* constan…
9756d8c
…ts to stable ABI manifest (#141910) (GH-141977)
These were added to the limited API in 3.5-3.12.
Not including them in `Misc/stable_abi.toml` was a bug.
(cherry picked from commit 202fce0)
encukou added a commit that referenced this pull request Nov 26, 2025
@encukou
[3.14]gh-141909: AddPyModuleDef_Slotand earlier Py_mod_* constan…
96bc021
…ts to stable ABI manifest (#141910) (GH-141978)
These were added to the limited API in 3.5-3.13.
Not including them in `Misc/stable_abi.toml` was a bug.
(cherry picked from commit 202fce0)
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou@StanFromIreland
pythongh-141909: AddPyModuleDef_Slotand earlier Py_mod_* constant…
6ae533b
…s to stable ABI manifest (python#141910)
These were added to the limited API in 3.5.
Not including them in `Misc/stable_abi.toml` was a bug.
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@encukou@ashm-dev
pythongh-141909: AddPyModuleDef_Slotand earlier Py_mod_* constant…
e2c4803
…s to stable ABI manifest (python#141910)
These were added to the limited API in 3.5.
Not including them in `Misc/stable_abi.toml` was a bug.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@encukouencukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@vstinner@serhiy-storchaka