Skip to content

GH-142050: Jit stencils on Windows contain debug data - #142052

Merged
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:shrink-stencils
Dec 3, 2025
Merged

GH-142050: Jit stencils on Windows contain debug data#142052
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:shrink-stencils

Conversation

@chris-eibl

@chris-eiblchris-eibl commented Nov 28, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Skipping .debug$S COFF sections fixes this.

@bedevere-appbedevere-appBot mentioned this pull request Nov 28, 2025
Closed
@chris-eiblchris-eibl changed the title GH-142050: Jit stencils on Windows contain debug data on WindowsGH-142050: Jit stencils on Windows contain debug dataNov 28, 2025
Fidget-Spinner
Fidget-Spinner approved these changes Nov 28, 2025
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for noticing this. Do you think this happened on 3.14 as well?

@chris-eibl

chris-eibl commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

No, as written in the issue I haven't seen that on 3.14. Neither on main for Linux in WSL.

I also haven't looked on ARM or Win32, yet.

A second pair of eyes can't hurt!

I think on 3.14 we're safe since no big changes will happen there anymore?

OTOH, the change is simple and small so better safe than sorry and backport?

There are other sections we might want to skip, maybe on other platforms, too.

But we can add them on a case-by-case basis when they start to hurt us ...

savannahostrowski
savannahostrowski approved these changes Dec 1, 2025
View reviewed changes
Comment threadMisc/NEWS.d/next/Build/2025-11-28-21-43-07.gh-issue-142050.PFi4tv.rst Outdated
@savannahostrowski

savannahostrowski commented Dec 1, 2025

Copy link
Copy Markdown
Member

Oops, I think my review comment got eaten by GitHub?

In any case, thanks for this!

I'm +1 on handling other debug section types on a case-by-case basis. I'd rather know that these have started appearing and understand why, rather than silently ignore them.

I probably wouldn't advocate for a backport either, FWIW...unless we know this is happening in 3.14.

@savannahostrowski
savannahostrowski enabled auto-merge (squash) December 3, 2025 21:43
@savannahostrowski
savannahostrowski merged commit 618dc36 into python:mainDec 3, 2025
72 checks passed
@chris-eibl
chris-eibl deleted the shrink-stencils branch December 4, 2025 18:09
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@chris-eibl@savannahostrowski@StanFromIreland
pythonGH-142050: Jit stencils on Windows contain debug data (python#1…
0626f90
…42052)
Co-authored-by: Savannah Ostrowski <savannah@python.org>
@chris-eiblchris-eibl mentioned this pull request Mar 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowskisavannahostrowskisavannahostrowski approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner
@diegorussodiegorussoAwaiting requested review from diegorussodiegorusso is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-eibl@savannahostrowski@Fidget-Spinner