gh-54872: Remove default OPT=-O for non-GCC compilers - #142159

Open

bobzinin wants to merge 2 commits into

python:mainfrom

bobzinin:fix-opt-default

bobzinin commented Dec 1, 2025•
edited
Loading

The configure script was setting OPT="-O" by default for non-GCC compilers, which could conflict with user-specified CFLAGS. This change removes the automatic default, allowing users full control over optimization flags via CFLAGS without unexpected conflicts.

Issue: configure shouldn't set a default OPT #54872

Remove default OPT=-O for non-GCC compilers

e712a28

The configure script was setting OPT="-O" by default for non-GCC
compilers, which could conflict with user-specified CFLAGS. This
change removes the automatic default, allowing users full control
over optimization flags via CFLAGS without unexpected conflicts.

bobzinin requested review from AA-Turner, corona10, emmatyping and erlend-aasland as code owners

December 1, 2025 18:34

bedevere-appBot commented Dec 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-appBot mentioned this pull request

subprocess.communicate() doesn't close pipes on Windows #54972

Closed

bedevere-appBot added the awaiting review label

bobzinin changed the title ~~gh-54972: Remove default OPT=-O for non-GCC compilers~~gh-54872: Remove default OPT=-O for non-GCC compilers

bedevere-appBot mentioned this pull request

configure shouldn't set a default OPT #54872

Open

python-cla-botBot commented Dec 1, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appBot commented Dec 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

StanFromIreland commented Dec 1, 2025

Member

You need to run make regen-configure.

bedevere-appBot commented Dec 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bobzinin force-pushed the fix-opt-default branch from 98956c5 to cd68588Compare

December 1, 2025 19:22

bedevere-appBot commented Dec 1, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Remove default OPT=-O for non-GCC compilers

6dc8463

bobzinin force-pushed the fix-opt-default branch from cd68588 to 6dc8463Compare

December 2, 2025 08:17

bedevere-appBot commented Dec 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

github-actionsBot commented May 2, 2026

This PR is stale because it has been open for 30 days with no activity.

github-actionsBot added the stale label

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale