Skip to content

gh-142163: Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set - #142164

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
ZeroIntensity:fix-numpy-shenanigans
Dec 2, 2025
Merged

gh-142163: Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set#142164
kumaraditya303 merged 3 commits into
python:mainfrom
ZeroIntensity:fix-numpy-shenanigans

Conversation

@ZeroIntensity

@ZeroIntensityZeroIntensity commented Dec 1, 2025•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Dec 1, 2025
Closed
@ZeroIntensity

ZeroIntensity commented Dec 1, 2025

Copy link
Copy Markdown
MemberAuthor

@ngoldbaum Would you mind verifying that this fixes NumPy?

@ngoldbaum

ngoldbaum commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Seems to work:

Python 3.15.0a2+ (heads/fix-numpy-shenanigans:2321c5a, Dec 1 2025, 16:34:55) [Clang 17.0.0 (clang-1700.4.4.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> numpy.__version__
'2.5.0.dev0+git20251201.fb0578d'
>>>

@tacaswell

tacaswell commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

lol, I like the branch name.

I can confirm that this fixes it for both

✘ 21:43:47 [belanna] @ clang++ --version
clang version 21.1.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
~
✔ 21:43:53 [belanna] @ g++ --version
g++ (GCC) 15.2.1 20251112
Copyright (C) 2025 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

kumaraditya303
kumaraditya303 approved these changes Dec 2, 2025
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303
kumaraditya303 merged commit 4172885 into python:mainDec 2, 2025
52 checks passed
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ZeroIntensity@StanFromIreland
pythongh-142163: Only defineHAVE_THREAD_LOCALwhenPy_BUILD_CORE…
d216ed1
… is set (python#142164)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZeroIntensity@ngoldbaum@tacaswell@kumaraditya303