Uh oh!
There was an error while loading. Please reload this page.
[3.14] gh-119452: Block until data is read - #142176
Closed
hugovk wants to merge 1 commit into
Closed
Conversation
hugovk
commented
Dec 2, 2025
MemberAuthor
!buildbot AMD64 Windows11 Non-Debug |
bedevere-bot
commented
Dec 2, 2025
🤖 New build scheduled with the buildbot fleet by @hugovk for commit 56a1e65 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142176%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
encukou
reviewed
Dec 2, 2025
| cursize = 0 | ||
| data = self.rfile.read(min(nbytes, _MIN_READ_BUF_SIZE)) | ||
| while (len(data) < nbytes and len(data) != cursize and | ||
| select.select([self.rfile._sock], [], [], 0)[0]): |
Member
There was a problem hiding this comment.
According to the current docs this should be omitted.
It might be better to document what None does: #142177
hugovk
commented
Dec 2, 2025
MemberAuthor
Windows builds are timing out on GitHub Actions: https://github.com/python/cpython/actions/runs/19851448458/job/56879004094?pr=142176 |
encukou added a commit
to encukou/cpython
that referenced
this pull request
Dec 2, 2025
This reads/writes data as available, making the CGI application responsible for managing any timeouts when receiving data from clients. Data is read in chunks of bounded size, and passed on immediately (except stderr, which is combined into a single message as before). This does need 3 threads. (As does process.communicate.)
hugovk
commented
Dec 2, 2025
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #119455 (comment), see also #119455 (review).